Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16434: [R][CI] Revert devdocs to setup-r@v1 for now #13050

Closed
wants to merge 2 commits into from

Conversation

wjones127
Copy link
Member

@wjones127 wjones127 commented May 2, 2022

I'm not 100% sure of the specific cause, but also don't think it's worth getting to the exact root since we will be replacing with UCRT version soon. It seems switching to setup-r@v2 broke our setup. My best guess is we unexpectedly were dependent on this line:

https://github.com/r-lib/actions/blob/2acb5b24ed4d2f8a065b600c903d5ee62bbbe893/setup-r/src/installer.ts#L382

But that we removed in v2 in:

r-lib/actions@18ab426

@wjones127
Copy link
Member Author

@github-actions crossbow submit test-r-devdocs

@github-actions
Copy link

github-actions bot commented May 2, 2022

@github-actions
Copy link

github-actions bot commented May 2, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

github-actions bot commented May 2, 2022

Revision: 2b65342

Submitted crossbow builds: ursacomputing/crossbow @ actions-1992

Task Status
test-r-devdocs Github Actions

V2 dropped this line:

```
core.addPath(`C:\\rtools40\\mingw64\\bin`);
```

Which likely was the cause. See diff:

r-lib/actions@18ab426
@wjones127 wjones127 marked this pull request as ready for review May 2, 2022 18:18
@wjones127 wjones127 changed the title ARROW-16434: [R][CI] Fix Windows devdocs ARROW-16434: [R][CI] Revert devdocs to setup-r@v1 for now May 2, 2022
@wjones127
Copy link
Member Author

cc @thisisnic

@thisisnic
Copy link
Member

cc @dragosmg too as I think you'd be interest to know about this!

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this one!

@thisisnic thisisnic closed this in 3c3e68c May 3, 2022
@jonkeane
Copy link
Member

jonkeane commented May 3, 2022

Thank you all!

@ursabot
Copy link

ursabot commented May 7, 2022

Benchmark runs are scheduled for baseline = 2025673 and contender = 3c3e68c. 3c3e68c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.12% ⬆️0.04%] test-mac-arm
[Finished ⬇️3.57% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3c3e68c1 ec2-t3-xlarge-us-east-2
[Finished] 3c3e68c1 test-mac-arm
[Finished] 3c3e68c1 ursa-i9-9960x
[Finished] 3c3e68c1 ursa-thinkcentre-m75q
[Finished] 2025673f ec2-t3-xlarge-us-east-2
[Finished] 2025673f test-mac-arm
[Finished] 2025673f ursa-i9-9960x
[Finished] 2025673f ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 7, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants