-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16434: [R][CI] Revert devdocs to setup-r@v1 for now #13050
Conversation
@github-actions crossbow submit test-r-devdocs |
|
Revision: 2b65342 Submitted crossbow builds: ursacomputing/crossbow @ actions-1992
|
V2 dropped this line: ``` core.addPath(`C:\\rtools40\\mingw64\\bin`); ``` Which likely was the cause. See diff: r-lib/actions@18ab426
cc @thisisnic |
cc @dragosmg too as I think you'd be interest to know about this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting to the bottom of this one!
Thank you all! |
Benchmark runs are scheduled for baseline = 2025673 and contender = 3c3e68c. 3c3e68c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
I'm not 100% sure of the specific cause, but also don't think it's worth getting to the exact root since we will be replacing with UCRT version soon. It seems switching to
setup-r@v2
broke our setup. My best guess is we unexpectedly were dependent on this line:https://github.com/r-lib/actions/blob/2acb5b24ed4d2f8a065b600c903d5ee62bbbe893/setup-r/src/installer.ts#L382
But that we removed in v2 in:
r-lib/actions@18ab426