Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15622: [R] Implement union_all and union for arrow_dplyr_query #13090

Closed
wants to merge 7 commits into from

Conversation

wjones127
Copy link
Member

@wjones127 wjones127 commented May 6, 2022

This PR adds support for dplyr::union and dplyr::union_all. Not sure why, but I find I must use the fully qualified name dplyr::union or else will get an error.

@github-actions
Copy link

github-actions bot commented May 6, 2022

@wjones127 wjones127 changed the title ARROW-15622: Implement union_all and union for arrow_dplyr_query ARROW-15622: [R] Implement union_all and union for arrow_dplyr_query May 9, 2022
@wjones127
Copy link
Member Author

Some example usage:

library(arrow)
#> 
#> Attaching package: 'arrow'
#> The following object is masked from 'package:utils':
#> 
#>     timestamp
library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union

tab1 <- arrow_table(x = 1:3)
tab2 <- arrow_table(x = 2:4, y = c("a", "b", "c"))

tab1 |>
    mutate(y = "a") |>
    union_all(tab2) |>
    collect()
#> # A tibble: 6 × 2
#>       x y    
#>   <int> <chr>
#> 1     2 a    
#> 2     3 b    
#> 3     4 c    
#> 4     1 a    
#> 5     2 a    
#> 6     3 a

tab1 |>
    mutate(y = "a") |>
    union_all(tab2) |>
    arrange(x, y) |>
    collect()
#> # A tibble: 6 × 2
#>       x y    
#>   <int> <chr>
#> 1     1 a    
#> 2     2 a    
#> 3     2 a    
#> 4     3 a    
#> 5     3 b    
#> 6     4 c

tab1 |>
    mutate(y = "a") |>
    dplyr::union(tab2) |>
    arrange(x, y) |>
    collect()
#> # A tibble: 5 × 2
#>       x y    
#>   <int> <chr>
#> 1     1 a    
#> 2     2 a    
#> 3     3 a    
#> 4     3 b    
#> 5     4 c

Created on 2022-05-09 by the reprex package (v2.0.1)

@wjones127 wjones127 marked this pull request as ready for review May 9, 2022 21:31
@wjones127
Copy link
Member Author

The timeouts on RTools mingw seem to be random. I ran locally on mingw64 and was able to get it to build and pass all R tests.

@nealrichardson
Copy link
Member

Not sure why, but I find I must use the fully qualified name dplyr::union or else will get an error.

Probably namespace collision:

> union
function (x, y) 
{
    u <- as.vector(x)
    v <- as.vector(y)
    unique(c(u, v))
}
<bytecode: 0x1290ae500>
<environment: namespace:base>

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions on the tests but otherwise LGTM, thanks!

r/tests/testthat/test-dplyr-union.R Outdated Show resolved Hide resolved
r/tests/testthat/test-dplyr-union.R Outdated Show resolved Hide resolved
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
@ursabot
Copy link

ursabot commented May 24, 2022

Benchmark runs are scheduled for baseline = 6576aa0 and contender = d889ade. d889ade is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.7% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.37% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.47% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d889adec ec2-t3-xlarge-us-east-2
[Failed] d889adec test-mac-arm
[Failed] d889adec ursa-i9-9960x
[Finished] d889adec ursa-thinkcentre-m75q
[Finished] 6576aa06 ec2-t3-xlarge-us-east-2
[Failed] 6576aa06 test-mac-arm
[Failed] 6576aa06 ursa-i9-9960x
[Finished] 6576aa06 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 24, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

kou pushed a commit that referenced this pull request Feb 20, 2023
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
…to GitHub issue numbers (apache#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	apache#5198
ARROW-6364	apache#5201
ARROW-6323	apache#5169
ARROW-6278	apache#5141
ARROW-6360	apache#5329
ARROW-6533	apache#5450
ARROW-6348	apache#5223
ARROW-6337	apache#5399
ARROW-10850	apache#9128
ARROW-10624	apache#9092
ARROW-10386	apache#8549
ARROW-6994	apache#23308
ARROW-12774	apache#10320
ARROW-12670	apache#10287
ARROW-16828	apache#13484
ARROW-14989	apache#13482
ARROW-16977	apache#13514
ARROW-13404	apache#10999
ARROW-16887	apache#13601
ARROW-15906	apache#13206
ARROW-15280	apache#13171
ARROW-16144	apache#13183
ARROW-16511	apache#13105
ARROW-16085	apache#13088
ARROW-16715	apache#13555
ARROW-16268	apache#13550
ARROW-16700	apache#13518
ARROW-16807	apache#13583
ARROW-16871	apache#13517
ARROW-16415	apache#13190
ARROW-14821	apache#12154
ARROW-16439	apache#13174
ARROW-16394	apache#13118
ARROW-16516	apache#13163
ARROW-16395	apache#13627
ARROW-14848	apache#12589
ARROW-16407	apache#13196
ARROW-16653	apache#13506
ARROW-14575	apache#13160
ARROW-15271	apache#13170
ARROW-16703	apache#13650
ARROW-16444	apache#13397
ARROW-15016	apache#13541
ARROW-16776	apache#13563
ARROW-15622	apache#13090
ARROW-18131	apache#14484
ARROW-18305	apache#14581
ARROW-18285	apache#14615
* Closes: apache#33631

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants