-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16548: [Python] Add pytest.mark.parquet to all tests under tests/parquet package #13147
Conversation
…s/parquet package
|
@jorisvandenbossche other solutions that fix this issue could be:
I was going in a rabbit hole on importlib and load_module but I don't think is worth the effort to spend more time on this having three possible solutions. |
Hmm, I would actually have expected that the |
…the pytest mark on each parquet python file
Thanks @jorisvandenbossche . I was able to reproduce the issue on each one of the test files individually. This solution solves the test failures when PARQUET is not enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from me assuming that it does solve the issue.
Benchmark runs are scheduled for baseline = 52a051b and contender = c032290. c032290 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
pytestmark = pytest.mark.parquet_encryption | ||
pytestmark = pytest.mark.parquet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we can't assign two marks this way (it is redefining the same variable), it should be something like pytestmark = [..., ...]
I think
If we built arrow and pyarrow without PARQUET and tried to run the PARQUET tests. The first test being executed was not correctly marked.
Meaning the test was not correctly skipped. This was found on the minimal builds PR: #13113 on this job failures: https://github.com/ursacomputing/crossbow/runs/6407176338?check_suite_focus=true
All tests under the parquet package are on the structure:
├── test_basic.py
├── test_compliant_nested_type.py
├── test_dataset.py
├── test_data_types.py
├── test_datetime.py
├── test_encryption.py
├── test_metadata.py
├── test_pandas.py
├── test_parquet_file.py
└── test_parquet_writer.py
The implementation marks all the individual tests that are on this structure with the parquet dataset mark correctly.