Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16570: [R] Make pkg-config commands find all of the libs #13151

Closed
wants to merge 1 commit into from

Conversation

nealrichardson
Copy link
Member

See discussion at https://lists.apache.org/thread/7brfhv6mzc392jqo04o1jp5vos7g7lnj

We don't currently have any CI that triggers the case @rvernica reported there.

@nealrichardson nealrichardson requested a review from kou May 13, 2022 14:08
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Can someone confirm that this solves the problem?

@kou
Copy link
Member

kou commented May 17, 2022

It seems that nobody can confirm this before we merge.

I'll merge this.

@kou kou closed this in cb5c039 May 17, 2022
@ursabot
Copy link

ursabot commented May 18, 2022

Benchmark runs are scheduled for baseline = a71e5f0 and contender = cb5c039. cb5c039 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.27% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.67% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cb5c039a ec2-t3-xlarge-us-east-2
[Failed] cb5c039a test-mac-arm
[Finished] cb5c039a ursa-i9-9960x
[Finished] cb5c039a ursa-thinkcentre-m75q
[Finished] a71e5f0d ec2-t3-xlarge-us-east-2
[Finished] a71e5f0d test-mac-arm
[Finished] a71e5f0d ursa-i9-9960x
[Finished] a71e5f0d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 18, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants