-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16654: [Dev][Archery] Support cherry-picking for major releases #13230
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested locally and all looks great to me. Just a really minor comment.
Thanks for doing this @kszucs !
return [] | ||
|
||
commit_range = "{}..{}".format(lower, upper) | ||
commit_range = f"{lower}..{upper}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the f-string changes. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
if not dry_run: | ||
release.cherry_pick_commits(recreate_branch=recreate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about moving dry_run
mode implementation to Release
?
if not dry_run: | |
release.cherry_pick_commits(recreate_branch=recreate) | |
release.cherry_pick_commits(recreate_branch=recreate, dry_run=dry_run) |
Release
knows what git
command lines should be ran. If we move dry_run
mode implementation to Release
, we can implement dry_run
mode and non dry_run
mode nearby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, but may handle it in follow-up PR.
Benchmark runs are scheduled for baseline = 0066e0e and contender = 02af333. 02af333 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Run the following to see what would happens without executing it:
Try creating a
maint-9.0.0
branch based off of themaster
branch:Now there should be the
maint-9.0.0
branch checked out locally. Rerunning the previous command with--continue
option would do nothing since there are no new commits to apply:So simulate new commits be resetting
maint-9.0.0
branch to three commits before the current master:Apply the new patches: