Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16708: [Dev] Replace basic auth with token auth for JIRA #13283

Merged
merged 11 commits into from
Jun 4, 2022

Conversation

assignUser
Copy link
Member

No description provided.

@assignUser assignUser marked this pull request as ready for review June 1, 2022 11:30
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

@kou
Copy link
Member

kou commented Jun 2, 2022

@github-actions autotune

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this with #13136 and this worked.

Could you also update dev/merge.conf.sample?

dev/merge_arrow_pr.py Outdated Show resolved Hide resolved
@assignUser assignUser requested a review from kou June 2, 2022 10:53
dev/merge.conf.sample Outdated Show resolved Hide resolved
dev/README.md Show resolved Hide resolved
dev/merge_arrow_pr.py Outdated Show resolved Hide resolved
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, assuming it works :-)

@kou
Copy link
Member

kou commented Jun 3, 2022

I confirmed this.

  • For merging: +1
  • For archery release changelog add: It works with invalid token. It seems that it works with anonymous access. How about removing the authentication feature?
diff --git a/dev/archery/archery/release.py b/dev/archery/archery/release.py
index 91dd129fdd..4b01716dad 100644
--- a/dev/archery/archery/release.py
+++ b/dev/archery/archery/release.py
@@ -85,11 +85,8 @@ class Issue:
 
 class Jira(JIRA):
 
-    def __init__(self, token=None,
-                 url='https://issues.apache.org/jira'):
-
-        token = token or os.environ.get('APACHE_JIRA_TOKEN')
-        super().__init__(url, token_auth=token)
+    def __init__(self, url='https://issues.apache.org/jira'):
+        super().__init__(url)
 
     def project_version(self, version_string, project='ARROW'):
         # query version from jira to populated with additional metadata

@assignUser
Copy link
Member Author

assignUser commented Jun 3, 2022

@kou I was under the impression that archery release curate requires the auth but I tested it and it also works without it (makes sense, it is just reading issues not writing like the merge script). I think removing it makes sense in this case unless there are other functions that require auth that I am missing @kszucs @raulcd ?

@raulcd
Copy link
Member

raulcd commented Jun 3, 2022

I've removed it and it seems not to be required for the cherry-pick command either:
archery release --jira-cache /tmp/jiracache cherry-pick 9.0.0
Unless we find a specific place where is required I am ok removing it.

dev/archery/archery/release.py Outdated Show resolved Hide resolved
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 25e0dd4 into apache:master Jun 4, 2022
@assignUser assignUser deleted the archery-jira-token-auth branch June 4, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants