-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16708: [Dev] Replace basic auth with token auth for JIRA #13283
Conversation
@github-actions autotune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed this with #13136 and this worked.
Could you also update dev/merge.conf.sample
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, assuming it works :-)
I confirmed this.
diff --git a/dev/archery/archery/release.py b/dev/archery/archery/release.py
index 91dd129fdd..4b01716dad 100644
--- a/dev/archery/archery/release.py
+++ b/dev/archery/archery/release.py
@@ -85,11 +85,8 @@ class Issue:
class Jira(JIRA):
- def __init__(self, token=None,
- url='https://issues.apache.org/jira'):
-
- token = token or os.environ.get('APACHE_JIRA_TOKEN')
- super().__init__(url, token_auth=token)
+ def __init__(self, url='https://issues.apache.org/jira'):
+ super().__init__(url)
def project_version(self, version_string, project='ARROW'):
# query version from jira to populated with additional metadata |
@kou I was under the impression that |
I've removed it and it seems not to be required for the cherry-pick command either: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.