ARROW-1845: [Python] Expose Decimal128Type #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
reviewed
Nov 22, 2017
python/pyarrow/types.pxi
Outdated
| @@ -967,7 +983,25 @@ cpdef DataType decimal(int precision, int scale=0): | |||
| decimal_type : DecimalType | |||
| """ | |||
| cdef shared_ptr[CDataType] decimal_type | |||
| decimal_type.reset(new CDecimalType(precision, scale)) | |||
| decimal_type.reset(new CDecimalType(byte_width, precision, scale)) | |||
| return pyarrow_wrap_data_type(decimal_type) | |||
There was a problem hiding this comment.
arrow::DecimalType is the base type now -- I don't think we should allow users to create instances of it
There was a problem hiding this comment.
Should I simply remove this function then?
There was a problem hiding this comment.
Yes, and the CDecimalType class in libarrow.pxd
Change-Id: I4ab257d47424c43426776e46fb46a02b5e89d7f0
|
Here's appveyor passing: https://ci.appveyor.com/project/xhochy/arrow/build/1.0.520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.