Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-8226: [Go] Add 64-bit offset Binary Builder and String Builder #13719

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

zeroshade
Copy link
Member

Initial support for Large Binary and Large String. The change is large enough as is so pushing the support through to the IPC module and others will be reserved for a subsequent change to this, same for updating the Parquet modules to support Large Binary and Large String.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@zeroshade
Copy link
Member Author

Since this is blocking more work on my end to push the Large types through I'll give this another day and then merge it tomorrow if no one has any objections.

@zeroshade zeroshade merged commit a4d4bd0 into apache:master Jul 29, 2022
@zeroshade zeroshade deleted the arrow-8226-large-offsets branch July 29, 2022 14:19
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 7fe71f5 and contender = a4d4bd0. a4d4bd0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️1.79% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.1% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] a4d4bd05 ec2-t3-xlarge-us-east-2
[Finished] a4d4bd05 test-mac-arm
[Failed] a4d4bd05 ursa-i9-9960x
[Finished] a4d4bd05 ursa-thinkcentre-m75q
[Failed] 7fe71f5c ec2-t3-xlarge-us-east-2
[Finished] 7fe71f5c test-mac-arm
[Finished] 7fe71f5c ursa-i9-9960x
[Finished] 7fe71f5c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants