Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17492: [C++] Hashing32/64 support for large var-binary types #13940

Merged
merged 4 commits into from
Sep 2, 2022
Merged

ARROW-17492: [C++] Hashing32/64 support for large var-binary types #13940

merged 4 commits into from
Sep 2, 2022

Conversation

rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Aug 22, 2022

@rtpsw
Copy link
Contributor Author

rtpsw commented Aug 22, 2022

cc @icexelloss

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17492

@rtpsw rtpsw mentioned this pull request Aug 22, 2022
Merged
@rtpsw
Copy link
Contributor Author

rtpsw commented Aug 23, 2022

@michalursa, could you review this or refer to someone?

@rtpsw
Copy link
Contributor Author

rtpsw commented Aug 26, 2022

@westonpace, could you review this? You should be familiar with most of this code now.

@rtpsw
Copy link
Contributor Author

rtpsw commented Aug 31, 2022

@westonpace, could you review this? You should be familiar with most of this code now.

Ping @westonpace

westonpace
westonpace approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super minor request. Otherwise, thanks for this addition and thanks for making sure to add tests.

cpp/src/arrow/compute/exec/key_hash_test.cc Outdated Show resolved Hide resolved
westonpace
westonpace requested changes Sep 2, 2022
View reviewed changes
cpp/src/arrow/compute/exec/key_hash_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/compute/exec/key_hash_test.cc Outdated Show resolved Hide resolved
rtpsw and others added 2 commits September 2, 2022 19:50
@rtpsw @westonpace
Rename test method
5b6bf9e 
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@rtpsw @westonpace
Rename test method
0df858a 
Co-authored-by: Weston Pace <weston.pace@gmail.com>
westonpace
westonpace approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this in.

@westonpace westonpace merged commit 672431b into apache:master Sep 2, 2022
@ursabot
Copy link

ursabot commented Sep 2, 2022

Benchmark runs are scheduled for baseline = 11bcde2 and contender = 672431b. 672431b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.55% ⬆️0.55%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 672431b5 ec2-t3-xlarge-us-east-2
[Failed] 672431b5 test-mac-arm
[Failed] 672431b5 ursa-i9-9960x
[Finished] 672431b5 ursa-thinkcentre-m75q
[Finished] 11bcde25 ec2-t3-xlarge-us-east-2
[Failed] 11bcde25 test-mac-arm
[Failed] 11bcde25 ursa-i9-9960x
[Finished] 11bcde25 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@rtpsw @zagto
ARROW-17492: [C++] Hashing32/64 support for large var-binary types (a…
b3a837d 
…pache#13940)

See https://issues.apache.org/jira/browse/ARROW-17492

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@rtpsw rtpsw deleted the ARROW-17492 branch October 13, 2022 14:14
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@rtpsw @fatemehp
ARROW-17492: [C++] Hashing32/64 support for large var-binary types (a…
4320baf 
…pache#13940)

See https://issues.apache.org/jira/browse/ARROW-17492

Lead-authored-by: Yaron Gvili <rtpsw@hotmail.com>
Co-authored-by: rtpsw <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtpsw @ursabot @westonpace