Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17594: [R][Packaging] Build binaries with devtoolset 8 on CentOS 7 #14243

Merged
merged 15 commits into from
Oct 10, 2022

Conversation

assignUser
Copy link
Member

@assignUser
Copy link
Member Author

@nealrichardson do you have time to take a look?
This should allow cento 7 users without devtoolset to install and use a binary package built on a system with dts (e.g. RSPM?).
I have opened https://issues.apache.org/jira/browse/ARROW-17849 to document these changes for centos 7 users.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

ci/docker/centos-7-cpp.dockerfile Outdated Show resolved Hide resolved
dev/tasks/r/github.packages.yml Outdated Show resolved Hide resolved
r/tools/nixlibs.R Show resolved Hide resolved
@nealrichardson
Copy link
Member

This should allow cento 7 users without devtoolset to install and use a binary package built on a system with dts (e.g. RSPM?).

We should test this

@assignUser
Copy link
Member Author

@nealrichardson test on a clean container of rstudio/r-base:4.2-centos7:

> install.packages("arrow_9.0.0.20220926_R_x86_64-pc-linux-gnu.tar.gz")
inferring 'repos = NULL' from 'pkgs'
* installing *binary* package ‘arrow’ ...
* DONE (arrow)
Making 'packages.html' ... done
> arrow::arrow_info()
Arrow package version: 9.0.0.20220926

Capabilities:
               
dataset    TRUE
substrait FALSE
parquet    TRUE
json       TRUE
s3         TRUE
gcs        TRUE
utf8proc   TRUE
re2        TRUE
snappy     TRUE
gzip       TRUE
brotli     TRUE
zstd       TRUE
lz4        TRUE
lz4_frame  TRUE
lzo       FALSE
bz2        TRUE
jemalloc   TRUE
mimalloc   TRUE
[# g++ --version
g++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@assignUser assignUser marked this pull request as ready for review September 30, 2022 09:50
@assignUser
Copy link
Member Author

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 7a69d15

Submitted crossbow builds: ursacomputing/crossbow @ actions-87fc31abbc

Task Status
r-binary-packages Github Actions

@assignUser
Copy link
Member Author

assignUser commented Sep 30, 2022

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 2595e3f

Submitted crossbow builds: ursacomputing/crossbow @ actions-92b9a4c60b

Task Status
r-binary-packages Github Actions

Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's more followup work to do before release, but this part LGTM, thanks for taking it on!

@nealrichardson nealrichardson merged commit 76d6cbb into apache:master Oct 10, 2022
@ursabot
Copy link

ursabot commented Oct 11, 2022

Benchmark runs are scheduled for baseline = 7f63ee5 and contender = 76d6cbb. 76d6cbb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.86% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 76d6cbb5 ec2-t3-xlarge-us-east-2
[Failed] 76d6cbb5 test-mac-arm
[Failed] 76d6cbb5 ursa-i9-9960x
[Finished] 76d6cbb5 ursa-thinkcentre-m75q
[Finished] 7f63ee50 ec2-t3-xlarge-us-east-2
[Failed] 7f63ee50 test-mac-arm
[Failed] 7f63ee50 ursa-i9-9960x
[Finished] 7f63ee50 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

nealrichardson pushed a commit that referenced this pull request Oct 11, 2022
Fix [typo](https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5277936316) introduced in #14243

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants