-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-14977: [Dev][CI] Add notify-token-expiration to archery #14978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
{%- if True -%} | ||
{%- endif -%} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was there because the comment block with the license generates an initial empty line that makes the email incorrect:
$ CROSSBOW_GITHUB_TOKEN=expired archery crossbow notify-token-expiration --days 40
From: None <None>
To: None
Subject: [CI] Arrow Crossbow Token Expiration in ALREADY_EXPIRED
The Arrow Crossbow Token will expire in 0 days.
Please generate a new Token. Send it to Apache INFRA to update the CROSSBOW_GITHUB_TOKEN.
Update it on the crossbow repository and in the Azure pipelines.
but I have pushed a minor change to strip the line on Python instead of Jinja because it was not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!!
…nja to improve clarity
Benchmark runs are scheduled for baseline = b03a8ad and contender = 6cfd143. 6cfd143 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This can be added to run weekly on crossbow similar to the email report generation tasks.
In the case of a non expired token:
In the case of an expired token:
In the case of a non-existing token: