Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-14977: [Dev][CI] Add notify-token-expiration to archery #14978

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Dec 15, 2022

This can be added to run weekly on crossbow similar to the email report generation tasks.

In the case of a non expired token:

$ CROSSBOW_GITHUB_TOKEN=${TOKEN} archery crossbow notify-token-expiration --days 30
Notification not sent. Token will expire in 39 days.

In the case of an expired token:

$ CROSSBOW_GITHUB_TOKEN=${TOKEN} archery crossbow notify-token-expiration --days 40
From: None <None>
To: None
Subject: [CI] Arrow Crossbow Token Expiration in 2023-01-23

The Arrow Crossbow Token will expire in 39 days.

Please generate a new Token. Send it to Apache INFRA to update the CROSSBOW_GITHUB_TOKEN.
Update it on the crossbow repository and in the Azure pipelines.

In the case of a non-existing token:

$ CROSSBOW_GITHUB_TOKEN=wrong_token archery crossbow notify-token-expiration --days 40
From: None <None>
To: None
Subject: [CI] Arrow Crossbow Token Expiration in ALREADY_EXPIRED

The Arrow Crossbow Token will expire in 0 days.

Please generate a new Token. Send it to Apache INFRA to update the CROSSBOW_GITHUB_TOKEN.
Update it on the crossbow repository and in the Azure pipelines.
* Closes: #14977

@github-actions
Copy link

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment on lines 19 to 20
{%- if True -%}
{%- endif -%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was there because the comment block with the license generates an initial empty line that makes the email incorrect:

$ CROSSBOW_GITHUB_TOKEN=expired archery crossbow notify-token-expiration --days 40

From: None <None>
To: None
Subject: [CI] Arrow Crossbow Token Expiration in ALREADY_EXPIRED

The Arrow Crossbow Token will expire in 0 days.

Please generate a new Token. Send it to Apache INFRA to update the CROSSBOW_GITHUB_TOKEN.
Update it on the crossbow repository and in the Azure pipelines.

but I have pushed a minor change to strip the line on Python instead of Jinja because it was not clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!!

@kou kou merged commit 6cfd143 into apache:master Dec 16, 2022
@ursabot
Copy link

ursabot commented Dec 17, 2022

Benchmark runs are scheduled for baseline = b03a8ad and contender = 6cfd143. 6cfd143 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.33% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.17% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6cfd143d ec2-t3-xlarge-us-east-2
[Failed] 6cfd143d test-mac-arm
[Finished] 6cfd143d ursa-i9-9960x
[Finished] 6cfd143d ursa-thinkcentre-m75q
[Finished] b03a8adf ec2-t3-xlarge-us-east-2
[Finished] b03a8adf test-mac-arm
[Finished] b03a8adf ursa-i9-9960x
[Finished] b03a8adf ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants