Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-326: Include scale and precision when materializing decimal writer #166

Closed
wants to merge 1 commit into from

Conversation

StevenMPhillips
Copy link
Contributor

No description provided.

${lowerName}(child.getName());
</#if>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a unit test that reproduces the problem you are fixing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@asfgit asfgit closed this in 8c8d341 Oct 11, 2016
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 2, 2018
Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#166 from xhochy/parquet-724 and squashes the following commits:

8b32f5f [Uwe L. Korn] PARQUET-724: Test more advanced properties setting
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 4, 2018
Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#166 from xhochy/parquet-724 and squashes the following commits:

8b32f5f [Uwe L. Korn] PARQUET-724: Test more advanced properties setting

Change-Id: I6fdbd9218d8cccb789a3bbf714af3fc9a6d51211
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 6, 2018
Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#166 from xhochy/parquet-724 and squashes the following commits:

8b32f5f [Uwe L. Korn] PARQUET-724: Test more advanced properties setting

Change-Id: I6fdbd9218d8cccb789a3bbf714af3fc9a6d51211
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 7, 2018
Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#166 from xhochy/parquet-724 and squashes the following commits:

8b32f5f [Uwe L. Korn] PARQUET-724: Test more advanced properties setting

Change-Id: I6fdbd9218d8cccb789a3bbf714af3fc9a6d51211
wesm pushed a commit to wesm/arrow that referenced this pull request Sep 8, 2018
Author: Uwe L. Korn <uwelk@xhochy.com>

Closes apache#166 from xhochy/parquet-724 and squashes the following commits:

8b32f5f [Uwe L. Korn] PARQUET-724: Test more advanced properties setting

Change-Id: I6fdbd9218d8cccb789a3bbf714af3fc9a6d51211
vfraga added a commit to rafael-telles/arrow that referenced this pull request Dec 14, 2021
rafael-telles pushed a commit to rafael-telles/arrow that referenced this pull request Jan 20, 2022
vfraga added a commit to rafael-telles/arrow that referenced this pull request Mar 29, 2022
zhouyuan pushed a commit to zhouyuan/arrow that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants