Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-2331: [Python] Fix indexing for negative or out-of-bounds indices #1770

Closed
wants to merge 2 commits into from
Closed

ARROW-2331: [Python] Fix indexing for negative or out-of-bounds indices #1770

wants to merge 2 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 20, 2018

No description provided.

xhochy
xhochy approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wesm
Copy link
Member

wesm commented Mar 22, 2018

Looks like we have a Windows int64->int cast issue. I can take a look if that would help

@pitrou pitrou force-pushed the ARROW-2331-python-indexing branch from bce1dc1 to aec1ef0 Compare March 23, 2018 09:11
@pitrou
Copy link
Member Author

pitrou commented Mar 23, 2018

Ok, the downcasting error should be fixed now. It's a pity these warnings don't appear on Linux (passing -Wconversion unfortunately enables other warnings).

@xhochy xhochy closed this in 777f986 Mar 23, 2018
@pitrou pitrou deleted the ARROW-2331-python-indexing branch March 23, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pitrou @wesm @xhochy