ARROW-2699: [C++/Python] Add Table method that replaces a column with a new supplied column #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a new supplied column
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 86.41% 86.39% -0.03%
==========================================
Files 242 230 -12
Lines 41534 40701 -833
==========================================
- Hits 35893 35162 -731
+ Misses 5641 5539 -102
Continue to review full report at Codecov.
|
wesm
reviewed
Jun 15, 2018
cpp/src/arrow/util/stl.h
Outdated
| const T& new_element) { | ||
| DCHECK_LE(index, values.size()); | ||
| std::vector<T> out; | ||
| out.reserve(values.size() + 1); |
There was a problem hiding this comment.
Can this append at the end? If not then remove the + 1 here
python/pyarrow/tests/test_table.py
Outdated
| col = pa.Column.from_array('d', data[1]) | ||
| t2 = table.set_column(0, col) | ||
|
|
||
| expected_data = copy.copy(data) |
| @@ -635,6 +635,30 @@ cdef class Schema: | |||
|
|
|||
| return pyarrow_wrap_schema(new_schema) | |||
|
|
|||
| def set(self, int i, Field field): | |||
There was a problem hiding this comment.
set_field for nominal consistency?
There was a problem hiding this comment.
I have sticked to set as we also have simply remove and insert on the Schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.