-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2745: [C++] ORC ExternalProject needs to declare dependency on vendored protobuf #2169
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
- Coverage 86.41% 86.39% -0.02%
==========================================
Files 242 230 -12
Lines 41622 40730 -892
==========================================
- Hits 35966 35188 -778
+ Misses 5656 5542 -114 Continue to review full report at Codecov.
|
set (ORC_VENDORED 1) | ||
else () | ||
set(ORC_VENDORED 1) | ||
add_dependencies(orc_ep lz4_static) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lz4_static
added twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, fixed.
ah, sorry for the oversimplification. I only tested the completely vendored and completely external use cases. |
…vendored protobuf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks @xhochy!
Sames Plasma failure as in other PRs. |
We need these dependencies as we otherwise get race conditions in the build.
cc @msarahan @kszucs