Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-2745: [C++] ORC ExternalProject needs to declare dependency on vendored protobuf #2169

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented Jun 26, 2018

We need these dependencies as we otherwise get race conditions in the build.

cc @msarahan @kszucs

@codecov-io
Copy link

Codecov Report

Merging #2169 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   86.41%   86.39%   -0.02%     
==========================================
  Files         242      230      -12     
  Lines       41622    40730     -892     
==========================================
- Hits        35966    35188     -778     
+ Misses       5656     5542     -114
Impacted Files Coverage Δ
rust/src/bitmap.rs
rust/src/datatypes.rs
rust/src/record_batch.rs
rust/src/memory.rs
rust/src/lib.rs
rust/src/error.rs
rust/src/buffer.rs
rust/src/list_builder.rs
rust/src/list.rs
rust/src/memory_pool.rs
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e757e7e...dd337fa. Read the comment docs.

set (ORC_VENDORED 1)
else ()
set(ORC_VENDORED 1)
add_dependencies(orc_ep lz4_static)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lz4_static added twice

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed.

@msarahan
Copy link
Contributor

ah, sorry for the oversimplification. I only tested the completely vendored and completely external use cases.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @xhochy!

@xhochy
Copy link
Member Author

xhochy commented Jun 26, 2018

Sames Plasma failure as in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants