Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3007: [Packaging] Remove needless dependencies #2391

Closed

Conversation

kou
Copy link
Member

@kou kou commented Aug 7, 2018

Dependencies should be computed by ${shlibs:Depends}. Because package name may
be different between distributions. For example, libcuda1 doesn't
exist on Ubuntu 18.04.

It should be computed by ${shlibs:Depends}. Because package name may
be different between distributions. For example, libcuda1 doesn't
exist on Ubuntu 18.04.
@codecov-io
Copy link

Codecov Report

Merging #2391 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2391   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         293      293           
  Lines       45471    45471           
=======================================
  Hits        38519    38519           
  Misses       6911     6911           
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0a63d...deab62c. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 29c4f76 Aug 7, 2018
@kou kou deleted the linux-packages-remove-needless-dependencies branch August 8, 2018 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants