Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift versions before 0.11 #2645

Closed
wants to merge 3 commits into from
Closed

PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift versions before 0.11 #2645

wants to merge 3 commits into from

Conversation

majetideepak
Copy link
Contributor

@majetideepak majetideepak commented Sep 27, 2018 •
edited by wesm
Loading

No description provided.

@majetideepak majetideepak force-pushed the PARQUET-1431 branch 2 times, most recently from 5453401 to ca8fbae Compare September 28, 2018 11:32
@wesm wesm changed the title PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift v… PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift versons before 0.11 Sep 29, 2018
wesm
wesm approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, rebased. Will merge after build runs

xhochy
xhochy approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@wesm
Copy link
Member

wesm commented Sep 29, 2018

This is broken, taking a look

@wesm
Copy link
Member

wesm commented Sep 29, 2018

I have no idea why THRIFT_VERSION VERSION_LESS "0.11.0" is not working properly. I've spent the last 10 minutes twiddling with it and do not know what is wrong

@wesm
Quote version to see if that makes it work
3d48f75 
Change-Id: Iec4e16517021f26cb957d9fc013be6e01b411cfc
@wesm
Copy link
Member

wesm commented Sep 29, 2018

Oh I see we need to do a regex

@wesm
Extract Thrift version with regex
72959da 
Change-Id: Icf773cf0f1456ca7ecec13ce9f105f9413df3fc1
@majetideepak majetideepak changed the title PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift versons before 0.11 PARQUET-1431: [C++] Automaticaly set thrift to use boost for thrift versions before 0.11 Sep 29, 2018
@majetideepak
Copy link
Contributor Author

+1 LGTM. Thanks or noticing the regex requirement @wesm.

@wesm wesm closed this in 2ccfd0a Sep 29, 2018
@asfimport asfimport mentioned this pull request Jun 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

@xhochy xhochy xhochy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majetideepak @wesm @xhochy