Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3725: [GLib] Add field readers to GArrowStructDataType #2923

Closed
wants to merge 2 commits into from

Conversation

kou
Copy link
Member

@kou kou commented Nov 8, 2018

No description provided.

@kou
Copy link
Member Author

kou commented Nov 8, 2018

@shiro615 Can you review this?

Copy link
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*/
gint
garrow_struct_data_type_get_field_index(GArrowStructDataType *data_type,
const gchar *name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two space indents are unnecessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kou
Copy link
Member Author

kou commented Nov 9, 2018

CI failure is unrelated.
I'll merge this.

@kou kou closed this in a1c00ac Nov 9, 2018
@kou kou deleted the glib-struct-data-type-field-readers branch November 9, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants