ARROW-81: [Format] Augment dictionary encoding metadata to accommodate additional use cases #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I07a001ed0614db8340addbc8f45f5a3af5d5cbed
|
lgtm |
|
Merging -- I'm open to discussing this further, perhaps after the 0.2 release |
|
LGTM |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 2, 2018
…Schema This is a follow up fix for [PARQUET-918](apache/parquet-cpp#295), do I need to create another jira for this? Looks like some .idea files are included by accident. It looks no harm. Do I need to revert them?@wesm cc @wesm @itaiin for reviewing Author: Xianjin YE <advancedxy@gmail.com> Closes apache#297 from advancedxy/master and squashes the following commits: e606d9d [Xianjin YE] Add .idea/ to .gitignore and make style check happy. 1adb192 [Xianjin YE] Add API doc for FromParquetSchema(parquet_schema, column_indices, out) 8de263b [Xianjin YE] Keep ordering in column indices when converting Parquet Schema to Arrow Schema
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 4, 2018
…Schema This is a follow up fix for [PARQUET-918](apache/parquet-cpp#295), do I need to create another jira for this? Looks like some .idea files are included by accident. It looks no harm. Do I need to revert them?@wesm cc @wesm @itaiin for reviewing Author: Xianjin YE <advancedxy@gmail.com> Closes apache#297 from advancedxy/master and squashes the following commits: e606d9d [Xianjin YE] Add .idea/ to .gitignore and make style check happy. 1adb192 [Xianjin YE] Add API doc for FromParquetSchema(parquet_schema, column_indices, out) 8de263b [Xianjin YE] Keep ordering in column indices when converting Parquet Schema to Arrow Schema Change-Id: I97447368cf803e5782c00abae4423bee967b7552
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 6, 2018
…Schema This is a follow up fix for [PARQUET-918](apache/parquet-cpp#295), do I need to create another jira for this? Looks like some .idea files are included by accident. It looks no harm. Do I need to revert them?@wesm cc @wesm @itaiin for reviewing Author: Xianjin YE <advancedxy@gmail.com> Closes apache#297 from advancedxy/master and squashes the following commits: e606d9d [Xianjin YE] Add .idea/ to .gitignore and make style check happy. 1adb192 [Xianjin YE] Add API doc for FromParquetSchema(parquet_schema, column_indices, out) 8de263b [Xianjin YE] Keep ordering in column indices when converting Parquet Schema to Arrow Schema Change-Id: I97447368cf803e5782c00abae4423bee967b7552
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 7, 2018
…Schema This is a follow up fix for [PARQUET-918](apache/parquet-cpp#295), do I need to create another jira for this? Looks like some .idea files are included by accident. It looks no harm. Do I need to revert them?@wesm cc @wesm @itaiin for reviewing Author: Xianjin YE <advancedxy@gmail.com> Closes apache#297 from advancedxy/master and squashes the following commits: e606d9d [Xianjin YE] Add .idea/ to .gitignore and make style check happy. 1adb192 [Xianjin YE] Add API doc for FromParquetSchema(parquet_schema, column_indices, out) 8de263b [Xianjin YE] Keep ordering in column indices when converting Parquet Schema to Arrow Schema Change-Id: I97447368cf803e5782c00abae4423bee967b7552
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…Schema This is a follow up fix for [PARQUET-918](apache/parquet-cpp#295), do I need to create another jira for this? Looks like some .idea files are included by accident. It looks no harm. Do I need to revert them?@wesm cc @wesm @itaiin for reviewing Author: Xianjin YE <advancedxy@gmail.com> Closes apache#297 from advancedxy/master and squashes the following commits: e606d9d [Xianjin YE] Add .idea/ to .gitignore and make style check happy. 1adb192 [Xianjin YE] Add API doc for FromParquetSchema(parquet_schema, column_indices, out) 8de263b [Xianjin YE] Keep ordering in column indices when converting Parquet Schema to Arrow Schema Change-Id: I97447368cf803e5782c00abae4423bee967b7552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @julienledem @nongli @jacques-n. I am hoping to close the loop on our discussion in https://issues.apache.org/jira/browse/ARROW-81. In my applications, I need the flexibility to transmit:
These features are needed for Python and R support, and in general for statistical computing applications.