Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-3938: [Packaging] Stop to refer java/pom.xml to get version information #3259

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Dec 24, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #3259 into master will increase coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3259      +/-   ##
==========================================
+ Coverage   88.53%   89.68%   +1.14%     
==========================================
  Files         539      481      -58     
  Lines       72836    68824    -4012     
==========================================
- Hits        64486    61722    -2764     
+ Misses       8245     7102    -1143     
+ Partials      105        0     -105
Impacted Files Coverage Δ
go/arrow/array/table.go
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/array/null.go
go/arrow/datatype_nested.go
go/arrow/array/string.go
go/arrow/math/uint64_avx2_amd64.go
go/arrow/array/builder.go
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d8bf2...3dce0a0. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I am not sure if there is a better solution, but this seems superior to the current situation. Thanks for working on this!

@wesm wesm closed this in 385c438 Dec 24, 2018
@kou kou deleted the stop-to-refer-pom-xml-for-version branch December 25, 2018 01:17
romainfrancois pushed a commit to romainfrancois/arrow that referenced this pull request Jan 3, 2019
…ormation

Author: Kouhei Sutou <kou@clear-code.com>

Closes apache#3259 from kou/stop-to-refer-pom-xml-for-version and squashes the following commits:

3dce0a0 <Kouhei Sutou>  Stop to refer java/pom.xml to get version information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants