ARROW-4157: [C++] Fix clang documentation warnings on Ubuntu 18.04 #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why these don't show up on Ubuntu 14.04. It would be nice if we could figure out how to get our CI to catch these |
|
+1 |
xhochy
reviewed
Jan 7, 2019
| /// value list of the dictionary | ||
| // Construct an Arrow StructArray representing the dictionary. | ||
| // Contains a field "keys" for the keys and "vals" for the values. | ||
| // \param val_list_data |
There was a problem hiding this comment.
I'm confused. Shouldn't this be /// to be picked up by doxygen?
There was a problem hiding this comment.
See serialize.cc. This is internal code and should not be showing up in Doxygen
emkornfield
pushed a commit
to emkornfield/arrow
that referenced
this pull request
Jan 10, 2019
I also added an option `ARROW_USE_CCACHE` to turn ccache on and off Author: Wes McKinney <wesm+git@apache.org> Closes apache#3310 from wesm/doc-fixes and squashes the following commits: e6c2f20 <Wes McKinney> Fix clang documentation warnings on Ubuntu 18.04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added an option
ARROW_USE_CCACHEto turn ccache on and off