Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-33850: [C++] Allow Substrait's default extension provider to be configured (fix) #34075

Merged
merged 1 commit into from
Feb 8, 2023
Merged

GH-33850: [C++] Allow Substrait's default extension provider to be configured (fix) #34075

merged 1 commit into from
Feb 8, 2023

Conversation

rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Feb 8, 2023 •
edited by github-actions bot
Loading

@rtpsw
Copy link
Contributor Author

rtpsw commented Feb 8, 2023

cc @icexelloss

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

@rtpsw rtpsw mentioned this pull request Feb 8, 2023
Merged
@westonpace
Copy link
Member

@github-actions crossbow submit test-ubuntu-18.04-cpp

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Revision: 268cf53

Submitted crossbow builds: ursacomputing/crossbow @ actions-51f4e7a1ba

Task Status
test-ubuntu-18.04-cpp Github Actions

@westonpace westonpace merged commit afbee08 into apache:master Feb 8, 2023
@westonpace
Copy link
Member

Thanks for the fix.

@rtpsw rtpsw deleted the GH-33850-fix branch February 8, 2023 20:20
@ursabot
Copy link

ursabot commented Feb 8, 2023

Benchmark runs are scheduled for baseline = 3e7b7e0 and contender = afbee08. afbee08 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.4% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.06% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] afbee088 ec2-t3-xlarge-us-east-2
[Failed] afbee088 test-mac-arm
[Failed] afbee088 ursa-i9-9960x
[Finished] afbee088 ursa-thinkcentre-m75q
[Failed] 3e7b7e0b ec2-t3-xlarge-us-east-2
[Failed] 3e7b7e0b test-mac-arm
[Failed] 3e7b7e0b ursa-i9-9960x
[Finished] 3e7b7e0b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Feb 10, 2023
@rtpsw @sjperkins
apacheGH-33850: [C++] Allow Substrait's default extension provider to…
1896406 
… be configured (fix) (apache#34075)

See [this post](apache#34042 (comment)) for background.
* Closes: apache#33850

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this pull request Feb 17, 2023
@rtpsw
apacheGH-33850: [C++] Allow Substrait's default extension provider to…
27201ad 
… be configured (fix) (apache#34075)

See [this post](apache#34042 (comment)) for background.
* Closes: apache#33850

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
@rtpsw @fatemehp
apacheGH-33850: [C++] Allow Substrait's default extension provider to…
cf070ef 
… be configured (fix) (apache#34075)

See [this post](apache#34042 (comment)) for background.
* Closes: apache#33850

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++] Allow Substrait's default extension provider to be configured
3 participants
@rtpsw @westonpace @ursabot