Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-34074: [GLib][FlightRPC] Add support for authentication #34090

Merged
merged 2 commits into from
Feb 10, 2023
Merged

GH-34074: [GLib][FlightRPC] Add support for authentication #34090

merged 2 commits into from
Feb 10, 2023

Conversation

kou
Copy link
Member

@kou kou commented Feb 9, 2023 •
edited by github-actions bot
Loading

Rationale for this change

Authentication related features are missing.

What changes are included in this PR?

New APIs:

  • gaflight_client_authenticate_basic_token()
  • GAFlightServerAuthSender
  • GAFlightServerAuthReader
  • GAFlightServerAuthHandler

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
apacheGH-34074: [GLib][FlightRPC] Add support for authentication
2a59063 
New APIs:

* `gaflight_client_authenticate_basic_token()`
* `GAFlightServerAuthSender`
* `GAFlightServerAuthReader`
* `GAFlightServerAuthHandler`
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

⚠️ GitHub issue #34074 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Feb 10, 2023

+1

@kou kou merged commit 106568d into apache:master Feb 10, 2023
@kou kou deleted the glib-flight-auth branch February 10, 2023 03:52
@ursabot
Copy link

ursabot commented Feb 10, 2023

Benchmark runs are scheduled for baseline = d512dd2 and contender = 106568d. 106568d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.55% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.77% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 106568d5 ec2-t3-xlarge-us-east-2
[Finished] 106568d5 test-mac-arm
[Finished] 106568d5 ursa-i9-9960x
[Finished] 106568d5 ursa-thinkcentre-m75q
[Finished] d512dd2e ec2-t3-xlarge-us-east-2
[Finished] d512dd2e test-mac-arm
[Finished] d512dd2e ursa-i9-9960x
[Finished] d512dd2e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Feb 10, 2023
@kou @sjperkins
apacheGH-34074: [GLib][FlightRPC] Add support for authentication (apa…
98a2a2e 
…che#34090)

### Rationale for this change

Authentication related features are missing.

### What changes are included in this PR?

New APIs:

* `gaflight_client_authenticate_basic_token()`
* `GAFlightServerAuthSender`
* `GAFlightServerAuthReader`
* `GAFlightServerAuthHandler`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34074

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this pull request Feb 17, 2023
@kou
apacheGH-34074: [GLib][FlightRPC] Add support for authentication (apa…
92ae3fe 
…che#34090)

### Rationale for this change

Authentication related features are missing.

### What changes are included in this PR?

New APIs:

* `gaflight_client_authenticate_basic_token()`
* `GAFlightServerAuthSender`
* `GAFlightServerAuthReader`
* `GAFlightServerAuthHandler`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34074

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Feb 24, 2023
@kou @fatemehp
apacheGH-34074: [GLib][FlightRPC] Add support for authentication (apa…
716c46e 
…che#34090)

### Rationale for this change

Authentication related features are missing.

### What changes are included in this PR?

New APIs:

* `gaflight_client_authenticate_basic_token()`
* `GAFlightServerAuthSender`
* `GAFlightServerAuthReader`
* `GAFlightServerAuthHandler`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34074

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: GLib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GLib][FlightRPC] Add gaflight_client_authenticate_basic_token()
2 participants
@kou @ursabot