Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Alpine linux nightly job is failing due to an invalid gtest #34869

Closed
westonpace opened this issue Apr 3, 2023 · 0 comments · Fixed by #34870
Closed

[C++] Alpine linux nightly job is failing due to an invalid gtest #34869

westonpace opened this issue Apr 3, 2023 · 0 comments · Fixed by #34870
Assignees
Milestone

Comments

@westonpace
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

It appears that the gtest that ships with Alpine does not meet the C++17 check. We can just download it.

Component(s)

C++

@kou kou closed this as completed in #34870 Apr 5, 2023
kou pushed a commit that referenced this issue Apr 5, 2023
…m source (#34870)

### Rationale for this change

The nightly test is currently failing with an error:

```
-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"
```

### What changes are included in this PR?

Changes the alpine linux nightly test to use `-DGTest_SOURCE="BUNDLED"`

### Are these changes tested?

Yes, by the nightly test itself.

### Are there any user-facing changes?

No
* Closes: #34869

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Apr 5, 2023
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…st from source (apache#34870)

### Rationale for this change

The nightly test is currently failing with an error:

```
-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"
```

### What changes are included in this PR?

Changes the alpine linux nightly test to use `-DGTest_SOURCE="BUNDLED"`

### Are these changes tested?

Yes, by the nightly test itself.

### Are there any user-facing changes?

No
* Closes: apache#34869

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
…st from source (apache#34870)

### Rationale for this change

The nightly test is currently failing with an error:

```
-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"
```

### What changes are included in this PR?

Changes the alpine linux nightly test to use `-DGTest_SOURCE="BUNDLED"`

### Are these changes tested?

Yes, by the nightly test itself.

### Are there any user-facing changes?

No
* Closes: apache#34869

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants