Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35038: [R] argument order in arrow_table affects object return type #35039

Merged
merged 6 commits into from
Apr 11, 2023
Merged

GH-35038: [R] argument order in arrow_table affects object return type #35039

merged 6 commits into from
Apr 11, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented Apr 11, 2023 •
edited by github-actions bot
Loading

@github-actions
Copy link

@thisisnic thisisnic marked this pull request as ready for review April 11, 2023 13:43
thisisnic and others added 2 commits April 11, 2023 16:06
@thisisnic @nealrichardson
Update r/tests/testthat/test-Table.R
499c638 
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
@thisisnic
Test actual types
e5dfdc6
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 11, 2023
nealrichardson
nealrichardson approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnic thisisnic merged commit 6b4e0f6 into apache:main Apr 11, 2023
@ursabot
Copy link

ursabot commented Apr 12, 2023

Benchmark runs are scheduled for baseline = aff876a and contender = 6b4e0f6. 6b4e0f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.37% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6b4e0f6d ec2-t3-xlarge-us-east-2
[Failed] 6b4e0f6d test-mac-arm
[Finished] 6b4e0f6d ursa-i9-9960x
[Finished] 6b4e0f6d ursa-thinkcentre-m75q
[Finished] aff876a5 ec2-t3-xlarge-us-east-2
[Failed] aff876a5 test-mac-arm
[Finished] aff876a5 ursa-i9-9960x
[Finished] aff876a5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@paleolimbot paleolimbot mentioned this pull request Apr 19, 2023
Open
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@thisisnic @nealrichardson @liujiacheng777
apacheGH-35038: [R] argument order in arrow_table affects object retu…
8db5c04 
…rn type (apache#35039)

* Closes: apache#35038

Lead-authored-by: Nic Crane <thisisnic@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@thisisnic @nealrichardson @ArgusLi
apacheGH-35038: [R] argument order in arrow_table affects object retu…
ab00eed 
…rn type (apache#35039)

* Closes: apache#35038

Lead-authored-by: Nic Crane <thisisnic@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@thisisnic @nealrichardson @rtpsw
apacheGH-35038: [R] argument order in arrow_table affects object retu…
86a2b20 
…rn type (apache#35039)

* Closes: apache#35038

Lead-authored-by: Nic Crane <thisisnic@gmail.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

Assignees
No one assigned
Labels
awaiting changes Awaiting changes Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] argument order in arrow_table affects object return type
3 participants
@thisisnic @ursabot @nealrichardson