Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35133: [Go] fix for math.MaxUint32 overflows int error in 32-bit arch #35159

Merged
merged 1 commit into from
Apr 17, 2023
Merged

GH-35133: [Go] fix for math.MaxUint32 overflows int error in 32-bit arch #35159

merged 1 commit into from
Apr 17, 2023

Conversation

sunpe
Copy link
Contributor

@sunpe sunpe commented Apr 16, 2023 •
edited by github-actions bot
Loading

Rationale for this change

When compiling on i386 arch, an error like math.MaxUint32 (untyped int constant 4294967295) overflows int will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast int to unint to avoid this error.

@sunpe sunpe requested a review from zeroshade as a code owner April 16, 2023 06:31
@github-actions
Copy link

@zeroshade zeroshade changed the title GH-35133:: fix for math.MaxUint32 overflows int error in 32-bit arch GH-35133: [Go] fix for math.MaxUint32 overflows int error in 32-bit arch Apr 16, 2023
@zeroshade zeroshade mentioned this pull request Apr 16, 2023
Closed
zeroshade
zeroshade approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I'll merge this after the CI passes

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 16, 2023
@zeroshade zeroshade merged commit becfaf3 into apache:main Apr 17, 2023
@ursabot
Copy link

ursabot commented Apr 19, 2023

Benchmark runs are scheduled for baseline = 5605cf5 and contender = becfaf3. becfaf3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.51% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.34% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] becfaf31 ec2-t3-xlarge-us-east-2
[Failed] becfaf31 test-mac-arm
[Finished] becfaf31 ursa-i9-9960x
[Finished] becfaf31 ursa-thinkcentre-m75q
[Finished] 5605cf5d ec2-t3-xlarge-us-east-2
[Failed] 5605cf5d test-mac-arm
[Finished] 5605cf5d ursa-i9-9960x
[Finished] 5605cf5d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

raulcd pushed a commit that referenced this pull request Apr 19, 2023
@sunpe @raulcd
GH-35133: [Go] fix for math.MaxUint32 overflows int error in 32-bit…
0b574ec 
… arch (#35159)

### Rationale for this change

When compiling on i386 arch, an error like `math.MaxUint32 (untyped int constant 4294967295) overflows int` will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast `int` to `unint` to avoid this error.

* Closes: #35133

Authored-by: sunpeng <sunpeng.dev@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@sunpe @liujiacheng777
apacheGH-35133: [Go] fix for math.MaxUint32 overflows int error in …
05cfbda 
…32-bit arch (apache#35159)

### Rationale for this change

When compiling on i386 arch, an error like `math.MaxUint32 (untyped int constant 4294967295) overflows int` will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast `int` to `unint` to avoid this error.

* Closes: apache#35133

Authored-by: sunpeng <sunpeng.dev@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@sunpe @ArgusLi
apacheGH-35133: [Go] fix for math.MaxUint32 overflows int error in …
b4192c6 
…32-bit arch (apache#35159)

### Rationale for this change

When compiling on i386 arch, an error like `math.MaxUint32 (untyped int constant 4294967295) overflows int` will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast `int` to `unint` to avoid this error.

* Closes: apache#35133

Authored-by: sunpeng <sunpeng.dev@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@sunpe @rtpsw
apacheGH-35133: [Go] fix for math.MaxUint32 overflows int error in …
11cd0bd 
…32-bit arch (apache#35159)

### Rationale for this change

When compiling on i386 arch, an error like `math.MaxUint32 (untyped int constant 4294967295) overflows int` will appear. The Int type is 32-bit and in 32-bit arch it overflows. In my PR, I cast `int` to `unint` to avoid this error.

* Closes: apache#35133

Authored-by: sunpeng <sunpeng.dev@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] Fails to build on 32-bit platforms
3 participants
@sunpe @ursabot @zeroshade