ARROW-4442: [JS] Add explicit type annotation to Chunked typeId getter #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
approved these changes
Feb 4, 2019
xhochy
pushed a commit
that referenced
this pull request
Feb 8, 2019
Closes https://issues.apache.org/jira/browse/ARROW-4442 Typescript is generating an overly broad type for the `typeId` property of the ChunkedVector class, leading to a type mismatch and failure to infer `Chunked<T>` is a `Vector<T>`: ```ts let col: Vector<Utf8>; col = new Chunked(new Utf8()); ^ /* Argument of type 'Chunked<Utf8>' is not assignable to parameter of type 'Vector<Utf8>'. Type 'Chunked<Utf8>' is not assignable to type 'Vector<Utf8>'. Types of property 'typeId' are incompatible. Type 'Type' is not assignable to type 'Type.Utf8'. */ ``` The type being generated currently is: ```ts readonly typeId: import("../enum").Type; ``` but it should be: ```ts readonly typeId: T['TType']; ``` The fix is to add an explicit return annotation to the Chunked `typeId` getter. Unfortunately this only affects the generated typings (`.d.ts` files) and not the library source, so it's difficult to test. We can look into whether there are any flags to trigger stricter type checking of the compiled code in the unit tests, but I don't know any off the top of my head. Author: ptaylor <paul.e.taylor@me.com> Closes #3538 from trxcllnt/js/add-chunked-typeId-annoation and squashes the following commits: 077f383 <ptaylor> add explicit type annotation to Chunked typeId getter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://issues.apache.org/jira/browse/ARROW-4442
Typescript is generating an overly broad type for the
typeIdproperty of the ChunkedVector class, leading to a type mismatch and failure to inferChunked<T>is aVector<T>:The type being generated currently is:
but it should be:
The fix is to add an explicit return annotation to the Chunked
typeIdgetter. Unfortunately this only affects the generated typings (.d.tsfiles) and not the library source, so it's difficult to test. We can look into whether there are any flags to trigger stricter type checking of the compiled code in the unit tests, but I don't know any off the top of my head.