Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4536: [GLib] Add data_type argument in garrow_list_array_new #3621

Closed
wants to merge 1 commit into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Feb 12, 2019

This pull-request adds data_type argument as the 1st argument of garrow_list_array_new() function to allow programmers to specify the field name of the resultant array.

@kou Please check this.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
Copy link
Member

kou commented Feb 12, 2019

Could you open a JIRA issue and prepend "ARROW-XXX: " to the title?

@mrkn mrkn changed the title Add data_type argument in garrow_list_array_new ARROW-4536: [GLib] Add data_type argument in garrow_list_array_new Feb 12, 2019
@mrkn
Copy link
Member Author

mrkn commented Feb 12, 2019

@kou I've done.

@kou kou closed this in 0c279eb Feb 12, 2019
@kou
Copy link
Member

kou commented Feb 12, 2019

Thanks. I've merged.

@mrkn mrkn deleted the fix_garrow_list_array_new branch February 12, 2019 06:51
trxcllnt pushed a commit to trxcllnt/arrow that referenced this pull request Feb 12, 2019
This pull-request adds `data_type` argument as the 1st argument of `garrow_list_array_new()` function to allow programmers to specify the field name of the resultant array.

@kou Please check this.

Author: Kenta Murata <mrkn@mrkn.jp>

Closes apache#3621 from mrkn/fix_garrow_list_array_new and squashes the following commits:

38aa2f7 <Kenta Murata> Add data_type argument in garrow_list_array_new
trxcllnt pushed a commit to trxcllnt/arrow that referenced this pull request Feb 12, 2019
This pull-request adds `data_type` argument as the 1st argument of `garrow_list_array_new()` function to allow programmers to specify the field name of the resultant array.

@kou Please check this.

Author: Kenta Murata <mrkn@mrkn.jp>

Closes apache#3621 from mrkn/fix_garrow_list_array_new and squashes the following commits:

38aa2f7 <Kenta Murata> Add data_type argument in garrow_list_array_new
tanyaschlusser pushed a commit to tanyaschlusser/arrow that referenced this pull request Feb 21, 2019
This pull-request adds `data_type` argument as the 1st argument of `garrow_list_array_new()` function to allow programmers to specify the field name of the resultant array.

@kou Please check this.

Author: Kenta Murata <mrkn@mrkn.jp>

Closes apache#3621 from mrkn/fix_garrow_list_array_new and squashes the following commits:

38aa2f7 <Kenta Murata> Add data_type argument in garrow_list_array_new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants