GH-37299: [C++] Fix clang-format version mismatch error with Homebrew's clang-format #37300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mac system, the version information is: Homebrew clang-format version 16.0.4, we should remove ^ symbol.
|
|
kou
approved these changes
Aug 22, 2023
github-actions
bot
added
awaiting merge
kou
changed the title
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b3936b9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…mebrew's clang-format (apache#37300) ### Rationale for this change On my mac system, the clang-format version information is: ``` ➜ ~ clang-format -version Homebrew clang-format version 16.0.4 ``` This isn't matched by the current clang-format regex in the CMake setup: ```cmake find_clang_tool(clang-format CLANG_FORMAT_BIN "^clang-format version ${ARROW_CLANG_TOOLS_VERSION_ESCAPED}") ``` ### What changes are included in this PR? Make regex more lenient to accomodate the Homebrew clang-format version string. ### Are these changes tested? no ### Are there any user-facing changes? no * Closes: apache#37299 Authored-by: light-city <455954986@qq.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
On my mac system, the clang-format version information is:
This isn't matched by the current clang-format regex in the CMake setup:
find_clang_tool(clang-format CLANG_FORMAT_BIN "^clang-format version ${ARROW_CLANG_TOOLS_VERSION_ESCAPED}")What changes are included in this PR?
Make regex more lenient to accomodate the Homebrew clang-format version string.
Are these changes tested?
no
Are there any user-facing changes?
no