GH-37795: [Java][FlightSQL] Add mock FlightSqlProducer and tests #37837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql.
kou
changed the title
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3c013da. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
etseidl
pushed a commit
to etseidl/arrow
that referenced
this pull request
Sep 28, 2023
apache#37837) ### Rationale for this change Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available to help developers write a FlightProducer. ### What changes are included in this PR? Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37795 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
apache#37837) ### Rationale for this change Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available to help developers write a FlightProducer. ### What changes are included in this PR? Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37795 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
apache#37837) ### Rationale for this change Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available to help developers write a FlightProducer. ### What changes are included in this PR? Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37795 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
stevelorddremio
pushed a commit
to stevelorddremio/arrow
that referenced
this pull request
Jan 19, 2024
apache#37837) Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available to help developers write a FlightProducer. Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql. Yes. No. * Closes: apache#37795 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
apache#37837) ### Rationale for this change Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available to help developers write a FlightProducer. ### What changes are included in this PR? Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests. Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations. Clean-up missed closes of FlightStreams in TestFlightSql. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37795 Authored-by: James Duong <duong.james@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Clarify how to write a FlightSqlProducer with examples and helper classes. This is more inline with what's available
to help developers write a FlightProducer.
What changes are included in this PR?
Add helper classes for creating a No-op Flight SQL producer and a partially implemented FlightSqlProducer that can process metadata requests.
Add a mock flight producer and tests for it based on the new FlightSqlProducer partial implementations.
Clean-up missed closes of FlightStreams in TestFlightSql.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.