GH-35770: [Go][Documentation] Update TimestampType zero value as seconds in comment #37905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmylife
changed the title
|
|
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit aca1d3e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
etseidl
pushed a commit
to etseidl/arrow
that referenced
this pull request
Sep 28, 2023
…s seconds in comment (apache#37905) ### Rationale for this change To clear the confusion around the zero value of `TimestampType` ### What changes are included in this PR? Just a comment change `nanosecond -> second` ### Are these changes tested? No need to test ### Are there any user-facing changes? No Closes: apache#35770 * Closes: apache#35770 Authored-by: ismail simsek <ismailsimsek09@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 23, 2023
…s seconds in comment (apache#37905) ### Rationale for this change To clear the confusion around the zero value of `TimestampType` ### What changes are included in this PR? Just a comment change `nanosecond -> second` ### Are these changes tested? No need to test ### Are there any user-facing changes? No Closes: apache#35770 * Closes: apache#35770 Authored-by: ismail simsek <ismailsimsek09@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…s seconds in comment (apache#37905) ### Rationale for this change To clear the confusion around the zero value of `TimestampType` ### What changes are included in this PR? Just a comment change `nanosecond -> second` ### Are these changes tested? No need to test ### Are there any user-facing changes? No Closes: apache#35770 * Closes: apache#35770 Authored-by: ismail simsek <ismailsimsek09@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…s seconds in comment (apache#37905) ### Rationale for this change To clear the confusion around the zero value of `TimestampType` ### What changes are included in this PR? Just a comment change `nanosecond -> second` ### Are these changes tested? No need to test ### Are there any user-facing changes? No Closes: apache#35770 * Closes: apache#35770 Authored-by: ismail simsek <ismailsimsek09@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
To clear the confusion around the zero value of
TimestampTypeWhat changes are included in this PR?
Just a comment change
nanosecond -> secondAre these changes tested?
No need to test
Are there any user-facing changes?
No
Closes: #35770