GH-32662: [C#] Make dictionaries in file and memory implementations work correctly and support integration tests #39146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
requested review from
assignUser,
kou,
raulcd and
westonpace
as code owners
CurtHagenlocher
commented
Dec 8, 2023
github-actions
bot
added
awaiting committer review
CurtHagenlocher
commented
Dec 8, 2023
|
Hmm... I seem to have made this ridiculously hard by misunderstanding the spec... . |
|
Going to rethink this a little |
…xpectations. Support dictionaries in C data interface integration testing.
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a5a366d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Dec 13, 2023
…ions work correctly and support integration tests (apache#39146) ### Rationale for this change While dictionary support was implemented for C# in apache#6870 for streams, support did not extend to files or memory buffers. This change rectifies that. ### What changes are included in this PR? Changes to the memory and file implementations to support reading and writing of dictionaries, including nested dictionaries. Changes to the integration tests so that they work with dictionaries. Enabling the dictionary tests in CI. ### Are these changes tested? Yes, both directly and indirectly via the integration tests. ### Are there any user-facing changes? No. * Closes: apache#32662 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
…ions work correctly and support integration tests (apache#39146) ### Rationale for this change While dictionary support was implemented for C# in apache#6870 for streams, support did not extend to files or memory buffers. This change rectifies that. ### What changes are included in this PR? Changes to the memory and file implementations to support reading and writing of dictionaries, including nested dictionaries. Changes to the integration tests so that they work with dictionaries. Enabling the dictionary tests in CI. ### Are these changes tested? Yes, both directly and indirectly via the integration tests. ### Are there any user-facing changes? No. * Closes: apache#32662 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…ions work correctly and support integration tests (apache#39146) ### Rationale for this change While dictionary support was implemented for C# in apache#6870 for streams, support did not extend to files or memory buffers. This change rectifies that. ### What changes are included in this PR? Changes to the memory and file implementations to support reading and writing of dictionaries, including nested dictionaries. Changes to the integration tests so that they work with dictionaries. Enabling the dictionary tests in CI. ### Are these changes tested? Yes, both directly and indirectly via the integration tests. ### Are there any user-facing changes? No. * Closes: apache#32662 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While dictionary support was implemented for C# in #6870 for streams, support did not extend to files or memory buffers. This change rectifies that.
What changes are included in this PR?
Changes to the memory and file implementations to support reading and writing of dictionaries, including nested dictionaries.
Changes to the integration tests so that they work with dictionaries.
Enabling the dictionary tests in CI.
Are these changes tested?
Yes, both directly and indirectly via the integration tests.
Are there any user-facing changes?
No.