-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-40398: [C++] Expose protobuf dependency if opentelemetry or ORC are enabled #40399
Conversation
|
5836fa4
to
cea9a8b
Compare
When not bundling dependencies, `libarrow.a` depends on protobuf symbols if built with ORC or opentelemetry support. However this dependency was not looked up in ArrowConfig.cmake, causing client projects using linking to `arrow_static` to fail in configuration.
cea9a8b
to
4e623f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
0d775ba
to
5ac6411
Compare
The CI failures seem unrelated. Anything I can do to move this forward? |
We can resolve these failures by rebasing on main. But I'll merge this. |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5baca0f. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…w-dev from libarrow-flight-dev (#40617) ### Rationale for this change This is a follow-up of GH-40399. ### What changes are included in this PR? Move `libprotobuf-dev` dependency to `libarrow-dev` from `libarrow-flight-dev`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #40615 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…strait (#40753) ### Rationale for this change The problem #40751 seems to be introduced by #40399. Though I'm not entirely sure about the purpose of that, it seems to be missing an `OR ARROW_SUBSTRAIT` in the `if` branch in 5baca0f#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aR1815 Because other than `ARROW_ORC`, `ARROW_WITH_OPENTELEMETRY` and `ARROW_FLIGHT`, `ARROW_SUBSTRAIT` also implies `ARROW_WITH_PROTOBUF`: https://github.com/apache/arrow/blob/5baca0f16e924c42741729f041b31a02883548b9/cpp/cmake_modules/ThirdpartyToolchain.cmake#L421-L423 ### What changes are included in this PR? Add the possible missing condition of `ARROW_SUBSTRAIT` for the questioning `if` branch. ### Are these changes tested? Manually tested. ### Are there any user-facing changes? None. * GitHub Issue: #40751 Lead-authored-by: Ruoxi Sun <zanmato1984@gmail.com> Co-authored-by: Rossi Sun <zanmato1984@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
When not bundling dependencies,
libarrow.a
depends on protobuf symbols if built with ORC or opentelemetry support. However this dependency was not looked up in ArrowConfig.cmake, causing client projects using linking toarrow_static
to fail in configuration.What changes are included in this PR?
This change makes it so that the dependency on
protobuf
is propagated to the installedArrowConfig.cmake
file when necessary.