GH-40398: [C++] Expose protobuf dependency if opentelemetry or ORC are enabled #40399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tobim
force-pushed
the
build/fix-protobuf-dependency
branch
from
5836fa4
to
cea9a8b
Compare
kou
reviewed
Mar 7, 2024
github-actions
bot
added
awaiting changes
tobim
changed the title
When not bundling dependencies, `libarrow.a` depends on protobuf symbols if built with ORC or opentelemetry support. However this dependency was not looked up in ArrowConfig.cmake, causing client projects using linking to `arrow_static` to fail in configuration.
tobim
force-pushed
the
build/fix-protobuf-dependency
branch
from
cea9a8b
to
4e623f4
Compare
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting merge
tobim
force-pushed
the
build/fix-protobuf-dependency
branch
from
0d775ba
to
5ac6411
Compare
github-actions
bot
added
awaiting change review
|
The CI failures seem unrelated. Anything I can do to move this forward? |
|
We can resolve these failures by rebasing on main. But I'll merge this. |
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 5baca0f. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Mar 17, 2024
kou
added a commit
that referenced
this pull request
Mar 18, 2024
…w-dev from libarrow-flight-dev (#40617) ### Rationale for this change This is a follow-up of GH-40399. ### What changes are included in this PR? Move `libprotobuf-dev` dependency to `libarrow-dev` from `libarrow-flight-dev`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #40615 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou
added a commit
that referenced
this pull request
Mar 24, 2024
…strait (#40753) ### Rationale for this change The problem #40751 seems to be introduced by #40399. Though I'm not entirely sure about the purpose of that, it seems to be missing an `OR ARROW_SUBSTRAIT` in the `if` branch in 5baca0f#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aR1815 Because other than `ARROW_ORC`, `ARROW_WITH_OPENTELEMETRY` and `ARROW_FLIGHT`, `ARROW_SUBSTRAIT` also implies `ARROW_WITH_PROTOBUF`: https://github.com/apache/arrow/blob/5baca0f16e924c42741729f041b31a02883548b9/cpp/cmake_modules/ThirdpartyToolchain.cmake#L421-L423 ### What changes are included in this PR? Add the possible missing condition of `ARROW_SUBSTRAIT` for the questioning `if` branch. ### Are these changes tested? Manually tested. ### Are there any user-facing changes? None. * GitHub Issue: #40751 Lead-authored-by: Ruoxi Sun <zanmato1984@gmail.com> Co-authored-by: Rossi Sun <zanmato1984@gmail.com> Co-authored-by: Sutou Kouhei <kou@cozmixng.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When not bundling dependencies,
libarrow.adepends on protobuf symbols if built with ORC or opentelemetry support. However this dependency was not looked up in ArrowConfig.cmake, causing client projects using linking toarrow_staticto fail in configuration.What changes are included in this PR?
This change makes it so that the dependency on
protobufis propagated to the installedArrowConfig.cmakefile when necessary.