Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Packaging][deb] libprotobuf-dev dependency is missing for libarrow-dev #40615

Closed
kou opened this issue Mar 17, 2024 · 1 comment
Closed

[Packaging][deb] libprotobuf-dev dependency is missing for libarrow-dev #40615

kou opened this issue Mar 17, 2024 · 1 comment
Assignees
@kou
Labels
Component: Packaging Type: bug
Milestone
16.0.0

Comments

@kou
Copy link
Member

kou commented Mar 17, 2024 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

GH-40399 moves FindProtobufAlt.cmake to cmake/Arrow/ from cmake/ArrowFlight/. So we need libprotobuf-dev to use find_package(Arrow). libarrow-dev not libarrow-flight-dev should depend on libprotobuf-dev.

debian-bookworm-amd64 https://github.com/ursacomputing/crossbow/actions/runs/8314136122/job/22750937879#step:11:1375

  -- Could NOT find Protobuf (missing: Protobuf_LIBRARIES Protobuf_INCLUDE_DIR) 
  CMake Error at CMakeLists.txt:24 (find_package):
    Found package configuration file:
  -- Configuring incomplete, errors occurred!
  See also "/build/minimal_build/CMakeFiles/CMakeOutput.log".
  
      /usr/lib/x86_64-linux-gnu/cmake/Arrow/ArrowConfig.cmake
  
    but it set Arrow_FOUND to FALSE so package "Arrow" is considered to be NOT
    FOUND.  Reason given by package:
  
    Arrow could not be found because dependency ProtobufAlt could not be found.

Component(s)

Packaging
@kou kou added the Type: bug label Mar 17, 2024
@kou kou changed the title [Packaging][deb] Move FindProtobufAlt.cmake to libarrow-dev from libarrow-flight-dev [Packaging][deb] libprotobuf-dev dependency is missing for libarrow-dev Mar 17, 2024
kou added a commit to kou/arrow that referenced this issue Mar 17, 2024
@kou
apacheGH-40615: [Packaging][deb] Move libprotobuf-dev dependency to l…
98991aa 
…ibarrow-dev from libarrow-flight-dev
@github-actions github-actions bot mentioned this issue Mar 17, 2024
Merged
kou added a commit that referenced this issue Mar 18, 2024
@kou
GH-40615: [Packaging][deb] Move libprotobuf-dev dependency to libarro…
2139359 
…w-dev from libarrow-flight-dev (#40617)

### Rationale for this change

This is a follow-up of GH-40399.

### What changes are included in this PR?

Move `libprotobuf-dev` dependency to `libarrow-dev` from `libarrow-flight-dev`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #40615

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Mar 18, 2024
@kou
Copy link
Member Author

kou commented Mar 18, 2024

Issue resolved by pull request 40617
#40617

@kou kou closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Packaging Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
1 participant
@kou