Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] CMake error for ninja-debug preset #40751

Closed
zanmato1984 opened this issue Mar 22, 2024 · 1 comment
Closed

[C++] CMake error for ninja-debug preset #40751

zanmato1984 opened this issue Mar 22, 2024 · 1 comment
Assignees
@zanmato1984
Labels
Component: C++ Type: bug
Milestone
16.0.0

Comments

@zanmato1984
Copy link
Collaborator

Describe the bug, including details regarding any error messages, version, and platform.

I'm building arrow cpp using CMake preset ninja-debug, with system provided protobuf:
cmake ../arrow/cpp --preset=ninja-debug

And got error message:

CMake Error at cmake_modules/ThirdpartyToolchain.cmake:1823 (message):
  ARROW_WITH_PROTOBUF must be propagated in the build tooling installation.
  Please extend the mappings of ARROW_PROTOBUF_ARROW_CMAKE_PACKAGE_NAME and
  ARROW_PROTOBUF_ARROW_PC_PACKAGE_NAME for newly introduced dependencies on
  protobuf.
Call Stack (most recent call first):
  CMakeLists.txt:543 (include)

Component(s)

C++
@zanmato1984 zanmato1984 mentioned this issue Mar 22, 2024
Merged
kou added a commit that referenced this issue Mar 24, 2024
@zanmato1984 @kou
GH-40751: [C++] Fix protobuf package name setting for builds with sub…
d5e9e13 
…strait (#40753)

### Rationale for this change

The problem #40751 seems to be introduced by #40399. Though I'm not entirely sure about the purpose of that, it seems to be missing an `OR ARROW_SUBSTRAIT` in the `if` branch in 5baca0f#diff-5cdc95f4e1b618f2f3ef10d370ce05a1ac05d9d401aecff3ccbb3d76bd366b6aR1815

Because other than `ARROW_ORC`, `ARROW_WITH_OPENTELEMETRY` and `ARROW_FLIGHT`, `ARROW_SUBSTRAIT` also implies `ARROW_WITH_PROTOBUF`:
https://github.com/apache/arrow/blob/5baca0f16e924c42741729f041b31a02883548b9/cpp/cmake_modules/ThirdpartyToolchain.cmake#L421-L423

### What changes are included in this PR?

Add the possible missing condition of `ARROW_SUBSTRAIT` for the questioning `if` branch.

### Are these changes tested?

Manually tested.

### Are there any user-facing changes?

None.

* GitHub Issue: #40751

Lead-authored-by: Ruoxi Sun <zanmato1984@gmail.com>
Co-authored-by: Rossi Sun <zanmato1984@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 16.0.0 milestone Mar 24, 2024
@kou
Copy link
Member

kou commented Mar 24, 2024

Issue resolved by pull request 40753
#40753

@kou kou closed this as completed Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanmato1984 zanmato1984

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
16.0.0
Development

No branches or pull requests
2 participants
@kou @zanmato1984