Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35081: [Python] construct pandas.DataFrame with public API in to_pandas #40897

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Mar 29, 2024

Rationale for this change

Avoiding using pandas internals to create Block objects ourselves, using a new API for pandas>=3

@jorisvandenbossche jorisvandenbossche changed the title [WIP] GH-35081: [Python] construct pandas.DataFrame with public API in to_pandas GH-35081: [Python] construct pandas.DataFrame with public API in to_pandas Apr 11, 2024
@apache apache deleted a comment from github-actions bot Apr 11, 2024
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review April 15, 2024 19:23
@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-pandas-upstream_devel test-conda-python-3.10-pandas-nightly

Copy link

Revision: f99132f

Submitted crossbow builds: ursacomputing/crossbow @ actions-4a17ce5567

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions

@jorisvandenbossche
Copy link
Member Author

@github-actions crossbow submit test-conda-python-3.11-pandas-upstream_devel test-conda-python-3.10-pandas-nightly

Copy link

Revision: f99132f

Submitted crossbow builds: ursacomputing/crossbow @ actions-99e6ea1ff1

Task Status
test-conda-python-3.10-pandas-nightly GitHub Actions
test-conda-python-3.11-pandas-upstream_devel GitHub Actions

@jorisvandenbossche jorisvandenbossche merged commit eb47fd6 into apache:main Apr 16, 2024
12 of 13 checks passed
@jorisvandenbossche jorisvandenbossche removed the awaiting committer review Awaiting committer review label Apr 16, 2024
@jorisvandenbossche jorisvandenbossche deleted the pandas-compat-constructor branch April 16, 2024 08:00
raulcd pushed a commit that referenced this pull request Apr 16, 2024
…pandas` (#40897)

### Rationale for this change

Avoiding using pandas internals to create Block objects ourselves, using a new API for pandas>=3

* GitHub Issue: #35081

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Copy link

After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit eb47fd6.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

tolleybot pushed a commit to tmct/arrow that referenced this pull request May 2, 2024
…n `to_pandas` (apache#40897)

### Rationale for this change

Avoiding using pandas internals to create Block objects ourselves, using a new API for pandas>=3

* GitHub Issue: apache#35081

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…n `to_pandas` (apache#40897)

### Rationale for this change

Avoiding using pandas internals to create Block objects ourselves, using a new API for pandas>=3

* GitHub Issue: apache#35081

Authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant