-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41287: [Java] ListViewVector Implementation #41285
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
In the case of PARQUET issues on JIRA the title also supports:
See also: |
ListView
Implementation WIP
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java
Outdated
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java
Show resolved
Hide resolved
java/vector/src/test/java/org/apache/arrow/vector/TestListViewVector.java
Outdated
Show resolved
Hide resolved
@lidavidm CIs are passing! |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0574988. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Apache Arrow format defines ListView and this has been introduced into other language bindings and the objective of this PR is to provide the initial ListView support to Java by adding `ListViewVector`. ### Non-Goals The following list of issues propose the extended work depending on this PR. They were separated to streamline the implementation process. - [ ] apache#41272 - [ ] apache#41286 - [ ] apache#41290 - [ ] apache#41288 - [ ] apache#41289 - [ ] apache#41269 - [ ] apache#41291 - [ ] apache#41292 - [ ] apache#41270 - [ ] apache#41293 - [ ] apache#41294 - [ ] apache#41569 - [ ] apache#41570 - [ ] apache#41584 - [ ] apache#41585 ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#41287 Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com> Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
Apache Arrow format defines ListView and this has been introduced into other language bindings and the objective of this PR is to provide the initial ListView support to Java by adding
ListViewVector
.Non-Goals
The following list of issues propose the extended work depending on this PR. They were separated to streamline the implementation process.
LargeListViewVector
Implementation #41272ListView
Implementation forColumnBinderArrowTypeVisitor
in JDBC #41286LargeListView
Implementation forColumnBinderArrowTypeVisitor
in JDBC #41290ListView
implementation forAvaticaParameterBinder
in JDBC #41288LargeListView
implementation forAvaticaParameterBinder
in JDBC #41289ListViewVector
Implementation transferPair implementation #41269LargeListViewVector
Implementation transferPair implementation #41291LargeListViewVector
Implementation copy implementation #41292ListViewVector
Implementation copy implementation #41270ListViewVector
implementation forConvertUtiils
in JDBC #41293LargeListViewVector
implementation forConvertUtiils
in JDBC #41294UnionListViewReader
#41569UnionListViewReader
#41570Are these changes tested?
Yes
Are there any user-facing changes?
No
ListViewVector
Implementation #41287