Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41287: [Java] ListViewVector Implementation #41285

Merged
merged 34 commits into from
May 16, 2024

Conversation

vibhatha
Copy link
Collaborator

@vibhatha vibhatha commented Apr 18, 2024

Rationale for this change

Apache Arrow format defines ListView and this has been introduced into other language bindings and the objective of this PR is to provide the initial ListView support to Java by adding ListViewVector.

Non-Goals

The following list of issues propose the extended work depending on this PR. They were separated to streamline the implementation process.

Are these changes tested?

Yes

Are there any user-facing changes?

No

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@vibhatha vibhatha changed the title [Java] ListView Implementation WIP GH-41287: [Java] ListViewVector Implementation [WIP] Apr 18, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes labels Apr 26, 2024
@github-actions github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Apr 30, 2024
@vibhatha vibhatha requested a review from lidavidm May 3, 2024 05:32
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels May 3, 2024
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels May 3, 2024
@vibhatha vibhatha marked this pull request as ready for review May 8, 2024 00:59
@vibhatha vibhatha requested a review from lidavidm May 8, 2024 01:00
@vibhatha vibhatha changed the title GH-41287: [Java] ListViewVector Implementation [WIP] GH-41287: [Java] ListViewVector Implementation May 8, 2024
@vibhatha
Copy link
Collaborator Author

@lidavidm CIs are passing!

@lidavidm lidavidm merged commit 0574988 into apache:main May 16, 2024
15 checks passed
@lidavidm lidavidm removed the awaiting merge Awaiting merge label May 16, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0574988.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha added a commit to vibhatha/arrow that referenced this pull request May 25, 2024
### Rationale for this change

Apache Arrow format defines ListView and this has been introduced into other language bindings and the objective of this PR is to provide the initial ListView support to Java by adding `ListViewVector`. 

### Non-Goals 

The following list of issues propose the extended work depending on this PR. They were separated to streamline the implementation process. 

- [ ] apache#41272
- [ ] apache#41286
- [ ] apache#41290
- [ ] apache#41288
- [ ] apache#41289
- [ ] apache#41269
- [ ] apache#41291
- [ ] apache#41292
- [ ] apache#41270
- [ ] apache#41293
- [ ] apache#41294
- [ ] apache#41569
- [ ] apache#41570
- [ ] apache#41584
- [ ] apache#41585

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* GitHub Issue: apache#41287

Lead-authored-by: Vibhatha Abeykoon <vibhatha@gmail.com>
Co-authored-by: Vibhatha Lakmal Abeykoon <vibhatha@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants