Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41611: [Docs][CI] Enable most sphinx-lint rules for documentation #41612

Merged
merged 5 commits into from
May 16, 2024

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented May 9, 2024

Rationale for this change

#41611

What changes are included in this PR?

  • Update to pre-commit config to enable all checks except dangling-hyphen, line-too-long by default
  • Associated fix docs

Are these changes tested?

Yes, by building and looking at the docs locally.

Are there any user-facing changes?

Just docs.

@amoeba amoeba changed the title GH-41611: [Docs][CI] Enable more sphinx-lint rules for documentation GH-41611: [Docs][CI] Enable most sphinx-lint rules for documentation May 10, 2024
@amoeba amoeba marked this pull request as ready for review May 16, 2024 00:34
@amoeba amoeba requested a review from raulcd as a code owner May 16, 2024 00:35
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me, thank!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 16, 2024
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlenkaF AlenkaF merged commit 07a30d9 into apache:main May 16, 2024
10 checks passed
@AlenkaF AlenkaF removed the awaiting merge Awaiting merge label May 16, 2024
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 16, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 07a30d9.

There was 1 benchmark result indicating a performance regression:

The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.

vibhatha pushed a commit to vibhatha/arrow that referenced this pull request May 25, 2024
…ation (apache#41612)

### Rationale for this change

apache#41611

### What changes are included in this PR?

- Update to pre-commit config to enable all checks except `dangling-hyphen`, `line-too-long` by default
- Associated fix docs

### Are these changes tested?

Yes, by building and looking at the docs locally.

### Are there any user-facing changes?

Just docs.
* GitHub Issue: apache#41611

Authored-by: Bryce Mecum <petridish@gmail.com>
Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants