-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41611: [Docs][CI] Enable most sphinx-lint rules for documentation #41612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me, thank!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 07a30d9. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ation (apache#41612) ### Rationale for this change apache#41611 ### What changes are included in this PR? - Update to pre-commit config to enable all checks except `dangling-hyphen`, `line-too-long` by default - Associated fix docs ### Are these changes tested? Yes, by building and looking at the docs locally. ### Are there any user-facing changes? Just docs. * GitHub Issue: apache#41611 Authored-by: Bryce Mecum <petridish@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Rationale for this change
#41611
What changes are included in this PR?
dangling-hyphen
,line-too-long
by defaultAre these changes tested?
Yes, by building and looking at the docs locally.
Are there any user-facing changes?
Just docs.