Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-41841: [R][CI] Remove more defunct rhub containers #41828

Merged
merged 11 commits into from
May 28, 2024

Conversation

jonkeane
Copy link
Member

@jonkeane jonkeane commented May 25, 2024

Testing CI to see if we can replicate the incoming NOTEs:

Found the following (possibly) invalid file URIs:
  URI: articles/read_write.html
    From: README.md
  URI: articles/data_wrangling.html
    From: README.md
  URI: reference/acero.html
    From: README.md
  URI: articles/install.html
    From: README.md
  URI: articles/install_nightly.html
    From: README.md

I wasn't able to replicate them in CI (even with _R_CHECK_CRAN_INCOMING_REMOTE_ set to true, and installing pandoc so that the docs could be munged.)

But in the process realized we were running old rhub images that aren't updated anymore (thanks, @thisisnic). Also did a bit of cleanup of --run-donttest which is now no longer needed (was removed in favor of the env var in 4.0)

Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 25, 2024
@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 9f39808

Submitted crossbow builds: ursacomputing/crossbow @ actions-a5b0b84826

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 4787953

Submitted crossbow builds: ursacomputing/crossbow @ actions-7808c7bd83

Task Status
test-r-linux-as-cran GitHub Actions

@thisisnic
Copy link
Member

Are we sure these jobs have recent enough versions of R?

@jonkeane
Copy link
Member Author

Are we sure these jobs have recent enough versions of R?

AAAAAAAAAAAAAH you're totally right these are the old rhub images which have stopped updating. I thought I caught all of these in my PRs last month, but must not have here! I'll bump those. Thank you!

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 3308bac

Submitted crossbow builds: ursacomputing/crossbow @ actions-3cca51e59a

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: ff98bc1

Submitted crossbow builds: ursacomputing/crossbow @ actions-3fc5d8254d

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 86dd932

Submitted crossbow builds: ursacomputing/crossbow @ actions-211370147c

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 49a6ac6

Submitted crossbow builds: ursacomputing/crossbow @ actions-9eada8f15b

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 2d62641

Submitted crossbow builds: ursacomputing/crossbow @ actions-5d28f4cf8f

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 8ecb4b4

Submitted crossbow builds: ursacomputing/crossbow @ actions-5ade7889bb

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 9d773e5

Submitted crossbow builds: ursacomputing/crossbow @ actions-019fb3b20f

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 3173612

Submitted crossbow builds: ursacomputing/crossbow @ actions-406ecd371b

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

@jonkeane jonkeane changed the title Testing: add remote testing to CRAN tests GH-41841: [R][CI] Remove more defunct rhub containers May 27, 2024
Copy link

⚠️ GitHub issue #41841 has been automatically assigned in GitHub to PR creator.

Copy link

Revision: f4a35d8

Submitted crossbow builds: ursacomputing/crossbow @ actions-890c1e4dc3

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 198d379

Submitted crossbow builds: ursacomputing/crossbow @ actions-0d251331a1

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 40bb3e4

Submitted crossbow builds: ursacomputing/crossbow @ actions-e294acd6f8

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: b997d12

Submitted crossbow builds: ursacomputing/crossbow @ actions-c4f9d1ebb7

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane
Copy link
Member Author

@github-actions crossbow submit test-r-linux-as-cran

Copy link

Revision: 852fc3a

Submitted crossbow builds: ursacomputing/crossbow @ actions-689141858e

Task Status
test-r-linux-as-cran GitHub Actions

@jonkeane jonkeane merged commit 8f3bf67 into apache:main May 28, 2024
38 checks passed
@jonkeane jonkeane removed the awaiting committer review Awaiting committer review label May 28, 2024
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8f3bf67.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants