-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-42228: [CI][Java] Suppress transfer progress log in java-jars #42230
Conversation
@github-actions crossbow submit java-jars |
|
This comment was marked as outdated.
This comment was marked as outdated.
I'm working on |
@github-actions crossbow submit java-jars |
Oh, it seems that we need more |
Are you working on this (reduce needless CI logs) too? |
Revision: b63fac4 Submitted crossbow builds: ursacomputing/crossbow @ actions-0f8f83d5a3
|
Ah! What I meant was just fixing errors related to |
I've merged the other PRs so java-jars should pass now |
Same error in both failing CIs. Cannot find protobuf? |
Related #42149 ? |
Ah! I see! |
Log size is reduced: Before: https://github.com/ursacomputing/crossbow/actions/runs/9594213517/job/26457788792
After: https://github.com/ursacomputing/crossbow/actions/runs/9606491188/job/26496791524
I'll merge this. |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c9a735a. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 47 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Transfer progress log is meaningless and noisy in CI log.
What changes are included in this PR?
Use the
--no-transfer-progress
option that is available Maven 3.6.1: https://maven.apache.org/ref/3.6.1/maven-embedder/cli.htmlOther approach is using
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
like other our scripts do.I chose
--no-transfer-progress
because it's shorter.Are these changes tested?
Yes.
Are there any user-facing changes?
No.