Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-42228: [CI][Java] Suppress transfer progress log in java-jars #42230

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

kou
Copy link
Member

@kou kou commented Jun 20, 2024

Rationale for this change

Transfer progress log is meaningless and noisy in CI log.

What changes are included in this PR?

Use the --no-transfer-progress option that is available Maven 3.6.1: https://maven.apache.org/ref/3.6.1/maven-embedder/cli.html

Other approach is using -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn like other our scripts do.

I chose --no-transfer-progress because it's shorter.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Jun 20, 2024

@github-actions crossbow submit java-jars

Copy link

⚠️ GitHub issue #42228 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 20, 2024

This comment was marked as outdated.

@assignUser
Copy link
Member

@llama90
Copy link
Contributor

llama90 commented Jun 21, 2024

I'm working on java-jars.

@kou
Copy link
Member Author

kou commented Jun 21, 2024

@github-actions crossbow submit java-jars

@kou
Copy link
Member Author

kou commented Jun 21, 2024

Oh, it seems that we need more --no-transfer-progress.

@kou
Copy link
Member Author

kou commented Jun 21, 2024

I'm working on java-jars.

Are you working on this (reduce needless CI logs) too?

Copy link

Revision: b63fac4

Submitted crossbow builds: ursacomputing/crossbow @ actions-0f8f83d5a3

Task Status
java-jars GitHub Actions

@llama90
Copy link
Contributor

llama90 commented Jun 21, 2024

I'm working on java-jars.

Are you working on this (reduce needless CI logs) too?

Ah! What I meant was just fixing errors related to java-jars. Some errors need to be fixed for a successful java-jars workflow.

@lidavidm
Copy link
Member

I've merged the other PRs so java-jars should pass now

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 21, 2024
@vibhatha
Copy link
Collaborator

Same error in both failing CIs. Cannot find protobuf?

@vibhatha
Copy link
Collaborator

Related #42149 ?

@kou
Copy link
Member Author

kou commented Jun 21, 2024

Ah! What I meant was just fixing errors related to java-jars. Some errors need to be fixed for a successful java-jars workflow.

Ah! I see!

@kou
Copy link
Member Author

kou commented Jun 21, 2024

Log size is reduced:

Before: https://github.com/ursacomputing/crossbow/actions/runs/9594213517/job/26457788792

...
41542 Error:  After correcting the problems, you can resume the build with the command
41543 Error:    mvn <args> -rf :flight-sql-jdbc-driver
41544 Error: Process completed with exit code 1.

After: https://github.com/ursacomputing/crossbow/actions/runs/9606491188/job/26496791524

...
12517 Error:  After correcting the problems, you can resume the build with the command
12518 Error:    mvn <args> -rf :flight-sql-jdbc-driver
12519 Error: Process completed with exit code 1.

I'll merge this.

@kou kou merged commit c9a735a into apache:main Jun 21, 2024
22 of 24 checks passed
@kou kou deleted the ci-java-jars-suppress-download-log branch June 21, 2024 21:46
@kou kou removed the awaiting merge Awaiting merge label Jun 21, 2024
Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c9a735a.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 47 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants