Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5387: [Go] properly handle sub-slice of List #4360

Closed
wants to merge 1 commit into from

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented May 21, 2019

No description provided.

@sbinet
Copy link
Contributor Author

sbinet commented May 21, 2019

@stuartcarnie @alexandreyc

@codecov-io
Copy link

Codecov Report

Merging #4360 into master will decrease coverage by 15.77%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4360       +/-   ##
===========================================
- Coverage    88.3%   72.52%   -15.78%     
===========================================
  Files         780       71      -709     
  Lines       98400     5947    -92453     
  Branches     1251        0     -1251     
===========================================
- Hits        86889     4313    -82576     
+ Misses      11275     1407     -9868     
+ Partials      236      227        -9
Impacted Files Coverage Δ
go/arrow/array/list.go 88.98% <100%> (+13.76%) ⬆️
python/pyarrow/ipc.pxi
cpp/src/arrow/csv/chunker-test.cc
cpp/src/parquet/column_page.h
cpp/src/parquet/bloom_filter-test.cc
cpp/src/arrow/array/builder_decimal.cc
cpp/src/plasma/client.cc
cpp/src/arrow/io/test-common.h
cpp/src/arrow/util/int-util-test.cc
cpp/src/arrow/python/io.cc
... and 702 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e4013...bbc8a83. Read the comment docs.

@sbinet
Copy link
Contributor Author

sbinet commented May 29, 2019

ping? (I'll wait 'till Friday before merging this in.)

Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbinet sbinet closed this in 17e85bf May 31, 2019
@sbinet sbinet deleted the issue-5387 branch May 31, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants