GH-43805: [C++] Enable filesystem automatically when one of ARROW_{AZURE,GCS,HDFS,S3}=ON is specified #43806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OW_{AZURE,GCS,HDFS,S3}=ON is specified
|
|
github-actions
bot
added
Component: C++
awaiting committer review
|
+1 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 75ca5b3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Sep 3, 2024
…OW_{AZURE,GCS,HDFS,S3}=ON is specified (apache#43806)
### Rationale for this change
`ARROW_{AZURE,GCS,HDFS,S3}=ON` are meaningful only when filesystem is enabled. If the user specified one of them, we can assume that the user wants to enable filesystem.
### What changes are included in this PR?
Enable `ARROW_FILESYSTEM` when one of `ARROW_{AZURE,GCS,HDFS,S3}=ON` are specified.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
`ARROW_FILESYSTEM` is enabled automatically with one of `ARROW_{AZURE,GCS,HDFS,S3}=ON`.
* GitHub Issue: apache#43805
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
…OW_{AZURE,GCS,HDFS,S3}=ON is specified (apache#43806)
### Rationale for this change
`ARROW_{AZURE,GCS,HDFS,S3}=ON` are meaningful only when filesystem is enabled. If the user specified one of them, we can assume that the user wants to enable filesystem.
### What changes are included in this PR?
Enable `ARROW_FILESYSTEM` when one of `ARROW_{AZURE,GCS,HDFS,S3}=ON` are specified.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
`ARROW_FILESYSTEM` is enabled automatically with one of `ARROW_{AZURE,GCS,HDFS,S3}=ON`.
* GitHub Issue: apache#43805
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ARROW_{AZURE,GCS,HDFS,S3}=ONare meaningful only when filesystem is enabled. If the user specified one of them, we can assume that the user wants to enable filesystem.What changes are included in this PR?
Enable
ARROW_FILESYSTEMwhen one ofARROW_{AZURE,GCS,HDFS,S3}=ONare specified.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
ARROW_FILESYSTEMis enabled automatically with one ofARROW_{AZURE,GCS,HDFS,S3}=ON.