ARROW-6034: [C++][Gandiva] Add string functions in Gandiva #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprudhvi
changed the title
pprudhvi
force-pushed
the
utf8-funcs
branch
2 times, most recently
from
e2f1742
to
54c8299
Compare
Codecov Report
@@ Coverage Diff @@
## master #4942 +/- ##
==========================================
+ Coverage 87.98% 89.15% +1.16%
==========================================
Files 910 722 -188
Lines 133521 101821 -31700
Branches 1418 0 -1418
==========================================
- Hits 117483 90779 -26704
+ Misses 16028 11042 -4986
+ Partials 10 0 -10
Continue to review full report at Codecov.
|
pravindra
reviewed
Jul 31, 2019
| @@ -68,7 +68,20 @@ std::vector<NativeFunction> GetStringFunctionRegistry() { | |||
|
|
|||
| NativeFunction("like", {}, DataTypeVector{utf8(), utf8()}, boolean(), | |||
| kResultNullIfNull, "gdv_fn_like_utf8_utf8", | |||
| NativeFunction::kNeedsFunctionHolder)}; | |||
| NativeFunction::kNeedsFunctionHolder), | |||
| NativeFunction("substr", {"substring"}, DataTypeVector{utf8(), int64(), int64()}, | |||
There was a problem hiding this comment.
These are non-obvious - can you please add comments for the params/functions ?
| uint64_t ctx_ptr = reinterpret_cast<int64>(&ctx); | ||
| int32 out_len = 0; | ||
|
|
||
| char* out_str = substr_utf8_int64_int64(ctx_ptr, "asdf", 4, 1, 2, &out_len); |
There was a problem hiding this comment.
can you please add a test for 0 len output ?
substr_utf8_int64_int64(ctx_ptr, "asdf", 4, 1, 0, &out_len)
kou
changed the title
pravindra
approved these changes
Aug 1, 2019
|
thanks for the change, @pprudhvi |
pprudhvi
added a commit
to pprudhvi/arrow
that referenced
this pull request
Aug 11, 2019
Add following functions in Gandiva: substr(str, offset, len), substr(str, offset), concat(str1, str2), castVARCHAR(timestamp, len), convert_fromUTF8(binary) Closes apache#4942 from pprudhvi/utf8-funcs and squashes the following commits: f88773e <Prudhvi Porandla> add len 0 substr unittest 3900f8e <Prudhvi Porandla> static cast size_t to int32 2082241 <Prudhvi Porandla> add convert_fromUTF8 method 112c933 <Prudhvi Porandla> add castVARCHAR(timestamp) method 77d3cdd <Prudhvi Porandla> add concatOperator 9e2623f <Prudhvi Porandla> add unittests for substr 48c4d08 <Prudhvi Porandla> add substr methods Authored-by: Prudhvi Porandla <prudhvi.porandla@icloud.com> Signed-off-by: Pindikura Ravindra <ravindra@dremio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add following functions in Gandiva:
substr(str, offset, len), substr(str, offset), concat(str1, str2), castVARCHAR(timestamp, len), convert_fromUTF8(binary)