Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-7311: [Python] Return filesystem and path from URI #5977

Closed
wants to merge 1 commit into from
Closed

ARROW-7311: [Python] Return filesystem and path from URI #5977

wants to merge 1 commit into from

Conversation

fhoering
Copy link
Contributor

@fhoering fhoering commented Dec 5, 2019

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 5, 2019

https://issues.apache.org/jira/browse/ARROW-7311

kszucs
kszucs requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhoering Please add tests.

@fhoering
Copy link
Contributor Author

fhoering commented Dec 9, 2019

OK. I will wait for the other PR #5990 to be merged.

I also would like to merge viewfs support #5957 first.

Actually I'm wondering why we even need to expose in Python HdfsFs and S3 FS. From a user perspective I could always get the fs resolution from the uri and everything else is internal. If it always returns the right fs I'm fine.

@kszucs
Copy link
Member

kszucs commented Jan 9, 2020

@fhoering you can rebase now

@fhoering
Copy link
Contributor Author

fhoering commented Jan 9, 2020

Yes will do.

@kszucs kszucs mentioned this pull request Jan 14, 2020
Closed
@fhoering
Copy link
Contributor Author

See #6197

@fhoering fhoering closed this Jan 15, 2020
jorisvandenbossche pushed a commit that referenced this pull request Jan 16, 2020
@kszucs @jorisvandenbossche
ARROW-7311: [Python] Return filesystem and path from URI
6642791 
This should supersede #5977

Closes #6197 from kszucs/fs-from-uri and squashes the following commits:

523972f <Krisztián Szűcs> relative paths
4b1f80b <Krisztián Szűcs> filesystem from uri
4ec33b1 <Krisztián Szűcs> from URI

Authored-by: Krisztián Szűcs <szucs.krisztian@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@asfimport asfimport mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhoering @kszucs