Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-7515: [C++] Rename nonexistent and non_existent to not_found #6139

Closed
wants to merge 9 commits into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Jan 8, 2020

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 8, 2020

@kszucs kszucs requested a review from pitrou January 12, 2020 10:55
@mrkn mrkn force-pushed the ARROW-7515 branch 2 times, most recently from 7c51c40 to a73c94c Compare January 14, 2020 02:55
@mrkn mrkn marked this pull request as ready for review January 14, 2020 08:50
@mrkn
Copy link
Member Author

mrkn commented Jan 21, 2020

@nealrichardson Could you tell me the way to fix the following warning?

https://github.com/apache/arrow/pull/6139/checks?check_run_id=395390711#step:5:988

* checking for code/documentation mismatches ... WARNING
Codoc mismatches from documentation object 'open_source':
open_source
  Code: function(path, filesystem = c("auto", "local"), format =
                 c("parquet", "arrow", "ipc"), partitioning = NULL,
                 allow_not_found = FALSE, recursive = TRUE, ...)
  Docs: function(path, filesystem = c("auto", "local"), format =
                 c("parquet", "arrow", "ipc"), partitioning = NULL,
                 allow_non_existent = FALSE, recursive = TRUE, ...)
  Argument names in code not in docs:
    allow_not_found
  Argument names in docs not in code:
    allow_non_existent
  Mismatches in argument names:
    Position: 5 Code: allow_not_found Docs: allow_non_existent

@nealrichardson
Copy link
Member

@mrkn edit r/man/open_source.Rd to match the inline doc source you edited. Better would be to run make doc from the r/ directory to regenerate the docs, though that requires that you have R set up and dependencies installed.

@wesm
Copy link
Member

wesm commented Mar 19, 2020

This needs to be rebased. @pitrou what do you think about this? I think it's okay

@mrkn
Copy link
Member Author

mrkn commented Mar 19, 2020

@kou I added a commit for renaming things in c_glib.

@pitrou
Copy link
Member

pitrou commented Mar 19, 2020

@mrkn Looks like the Ruby tests fails on Github Actions. You may be able to reproduce locally using:

docker-compose run ubuntu-ruby

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I've pushed some more nonexistent to not-found changes.
And I've fixed GLib test failures.

@mrkn
Copy link
Member Author

mrkn commented Mar 20, 2020

@kou thank you!

@kou
Copy link
Member

kou commented Mar 20, 2020

I found more "nonexistent".
I've renamed them to "not found".
Python jobs will be green.

@mrkn
Copy link
Member Author

mrkn commented Mar 23, 2020

@kou Thank you, again!

@pitrou Could you review this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants