ARROW-7796: [R] write_* functions should invisibly return their inputs #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
requested changes
Feb 7, 2020
Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
|
🤦♂ it's/its. Sorry about that. NEWS item added. Thanks for this great package! |
Co-Authored-By: Neal Richardson <neal.p.richardson@gmail.com>
|
Thanks again! |
nealrichardson
pushed a commit
to nealrichardson/arrow
that referenced
this pull request
Feb 13, 2020
I had some trouble building from source on Windows but I thought the changes were simple enough that I just went ahead. Tests and documentation also updated. Closes apache#6387 from boshek/write_return and squashes the following commits: d4d1ead <Sam Albers> Update r/NEWS.md 5f0e316 <Sam Albers> Merge branch 'master' into write_return 5d32579 <Sam Albers> update NEWS 53c3ab9 <Sam Albers> Update r/tests/testthat/test-read-write.R 673de49 <Sam Albers> Update r/tests/testthat/test-feather.R 11db34c <Sam Albers> Update r/tests/testthat/test-parquet.R 12222d6 <Sam Albers> update documentation 3768d0f <Sam Albers> return invisibly a595854 <Sam Albers> write_arrow returns input cac8db8 <Sam Albers> write_feather returns input f6b79de <Sam Albers> write_parquet returns input Lead-authored-by: Sam Albers <sam.albers@gov.bc.ca> Co-authored-by: Sam Albers <sam.albers@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble building from source on Windows but I thought the changes were simple enough that I just went ahead. Tests and documentation also updated.