ARROW-7833: [R] Make install_arrow() actually install arrow #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this now in order to resubmit to CRAN; happy to address any feedback in a followup. |
nealrichardson
added a commit
to nealrichardson/arrow
that referenced
this pull request
Feb 13, 2020
`install_arrow()` now takes a few arguments, which let you * Install the latest CRAN version (no arguments) * Install the latest nightly build (`install_arrow(nightly = TRUE)`) * Install with Linux C++ binaries by default (they are off by default in the current CRAN release), and conveniently change that setting without messing with env vars * Ignore system-installed arrow packages by default (to ensure that R and C++ versions match) It will also attempt to reload the package after installation, if `pkgload` is available. The other important change in this patch is to make `LIBARROW_DOWNLOAD` off by default, in order to appease CRAN. This unfortunately makes Linux installation only "just work" if you have set an env var. Other improvements in this patch: * Rename the env var `LIBARROW_BINARY_DISTRO` to `LIBARROW_BINARY` (brevity, and it also takes boolean values to enable or disable binary downloading) * Fix the default value setting of that variable * Update installation guide and README accordingly * Remove README.Rmd and just keep the static README.md. There's no value for us to have an R Markdown readme and have to worry about keeping it in sync; we have vignettes and help pages for examples. Closes apache#6406 from nealrichardson/install-arrow-binary and squashes the following commits: 767668c <Neal Richardson> Script fixes 4a1550e <Neal Richardson> LIBARROW_BINARY on should entail download_ok 4710500 <Neal Richardson> Update docs for new configure reality 660d0e7 <Neal Richardson> LIBARROW_DOWNLOAD is false by default now 3e02b72 <Neal Richardson> Reload the package if loaded already c731542 <Neal Richardson> Fix for the fix 42dc327 <Neal Richardson> Fix test setup e48ecbb <Neal Richardson> Docs e92f4b7 <Neal Richardson> Make these tests always run 87951bd <Neal Richardson> Update readme and add message e886116 <Neal Richardson> Delete README.Rmd (keep static README.md) bcd0237 <Neal Richardson> Update docs a459b49 <Neal Richardson> Switch var name to LIBARROW_BINARY 705d28a <Neal Richardson> Fix default value of LIBARROW_BINARY_DISTRO 7ff1365 <Neal Richardson> Change install_arrow() to actually install Authored-by: Neal Richardson <neal.p.richardson@gmail.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
wesm
reviewed
Feb 14, 2020
| @@ -21,28 +21,19 @@ dst_dir <- paste0("libarrow/arrow-", VERSION) | |||
|
|
|||
| arrow_repo <- "https://dl.bintray.com/ursalabs/arrow-r/libarrow/" | |||
| apache_src_url <- paste0( | |||
| "https://www.apache.org/dyn/closer.cgi/arrow/arrow-", VERSION, | |||
| "https://archive.apache.org/dist/arrow/arrow-", VERSION, | |||
There was a problem hiding this comment.
ASF release policies advise against this -- maybe let's open a JIRA about making the mirror resolution more robust?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_arrow()now takes a few arguments, which let youinstall_arrow(nightly = TRUE))It will also attempt to reload the package after installation, if
pkgloadis available.The other important change in this patch is to make
LIBARROW_DOWNLOADoff by default, in order to appease CRAN. This unfortunately makes Linux installation only "just work" if you have set an env var.Other improvements in this patch:
LIBARROW_BINARY_DISTROtoLIBARROW_BINARY(brevity, and it also takes boolean values to enable or disable binary downloading)