ARROW-7615: [CI][Gandiva] Ensure gandiva_jni library has only a whitelisted set of shared dependencies #6423
Conversation
|
@ursabot crossbow submit -g gandiva |
|
AMD64 Conda Crossbow Submit (#90712) builder has been succeeded. Revision: 4f10a74 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-506
|
| @@ -53,6 +53,9 @@ script: | |||
| - dev/tasks/gandiva-jars/build-cpp-osx.sh || travis_terminate 1 | |||
| - dev/tasks/gandiva-jars/build-java.sh || travis_terminate 1 | |||
| # deploy using crossbow | |||
| # pip install pygit2 fails if MACOS_DEPLOYMENT_TARGET is set to an earlier version. Since the | |||
| # gandiva libraries are already built we can reset MACOS_DEPLOYMENT_TARGET to curresnt osx version | |||
There was a problem hiding this comment.
nit! curresnt ->current
| @@ -23,9 +23,33 @@ CPP_BUILD_DIR=$TRAVIS_BUILD_DIR/dist/ | |||
|
|
|||
| pushd java | |||
| if [ $TRAVIS_OS_NAME == "linux" ]; then | |||
| ldd $CPP_BUILD_DIR/libgandiva_jni.so | |||
| SO_DEP=ldd | |||
There was a problem hiding this comment.
should we do this config based..so that it does not affect the nightly ones that the arrow community has..
There was a problem hiding this comment.
Added the check inside an if condition to see if environment variable CHECK_SHARED_DEPENDENCIES is set. The variable can be set in travis repository settings.
|
@ursabot crossbow submit -g gandiva |
|
AMD64 Conda Crossbow Submit (#90757) builder has been succeeded. Revision: d03c3e3 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-508
|
|
@ursabot crossbow submit -g gandiva |
|
AMD64 Conda Crossbow Submit (#90852) builder has been succeeded. Revision: fefe0d1 Submitted crossbow builds: ursa-labs/crossbow @ ursabot-510
|
No description provided.