Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-8028: [Go] Allow duplicate field names in schemas and nested types #6580

Closed
wants to merge 1 commit into from
Closed

ARROW-8028: [Go] Allow duplicate field names in schemas and nested types #6580

wants to merge 1 commit into from

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Mar 11, 2020

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-8028

@sbinet
Copy link
Contributor Author

sbinet commented Mar 11, 2020

PTAL @alexandreyc @stuartcarnie @richardartoul

alexandreyc
alexandreyc reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@alexandreyc alexandreyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for FieldIndex which can be shortened

alexandreyc
alexandreyc reviewed Mar 11, 2020
View reviewed changes
go/arrow/schema.go Outdated Show resolved Hide resolved
bkietz
bkietz reviewed Mar 11, 2020
View reviewed changes
go/arrow/schema.go Outdated Show resolved Hide resolved
stuartcarnie
stuartcarnie approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

@sbinet sbinet closed this in 777d9fc Mar 13, 2020
@sbinet sbinet deleted the issue-8028 branch March 13, 2020 11:09
@kylebrandt kylebrandt mentioned this pull request Apr 15, 2020
Closed
@asfimport asfimport mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkietz bkietz bkietz left review comments

@alexandreyc alexandreyc alexandreyc left review comments

@stuartcarnie stuartcarnie stuartcarnie approved these changes

Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbinet @stuartcarnie @bkietz @alexandreyc