-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-8060: [Python] Make dataset Expression objects serializable #6702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! added some comments
Is there a JIRA about defining a e.g. Flatbuffers-based serialization protocol (probably better than Protobuf so we avoid having to introduce a library dependency) for expressions? Seems like it might provide a more scalable solution for serialization and could eventually succeed the strategy here |
Created JIRA https://issues.apache.org/jira/browse/ARROW-8214 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, build failure is unrelated.
The Scalar are not properly exposed yet and the C++ implementation will change soon so while the serialization will work, we need to refactor this code.